From 651320a2979439b92c3971860047a836e5d8794a Mon Sep 17 00:00:00 2001 From: sayakpaul Date: Mon, 19 Feb 2024 16:16:08 +0530 Subject: [PATCH] make tests conditional and other things. --- .github/workflows/pr_dependency_test.yml | 2 + .github/workflows/pr_flax_dependency_test.yml | 2 + .github/workflows/pr_quality.yml | 49 ------------------- .github/workflows/pr_test_peft_backend.yml | 40 +++++++++++++++ .github/workflows/pr_tests.yml | 46 +++++++++++++++++ .../workflows/pr_torch_dependency_test.yml | 2 + .github/workflows/push_tests.yml | 5 +- .github/workflows/push_tests_fast.yml | 4 ++ .github/workflows/push_tests_mps.yml | 3 ++ 9 files changed, 103 insertions(+), 50 deletions(-) delete mode 100644 .github/workflows/pr_quality.yml diff --git a/.github/workflows/pr_dependency_test.yml b/.github/workflows/pr_dependency_test.yml index 102414076d81..0839497ed732 100644 --- a/.github/workflows/pr_dependency_test.yml +++ b/.github/workflows/pr_dependency_test.yml @@ -4,6 +4,8 @@ on: pull_request: branches: - main + paths: + - "src/diffusers/**.py" push: branches: - main diff --git a/.github/workflows/pr_flax_dependency_test.yml b/.github/workflows/pr_flax_dependency_test.yml index d7d2a2d4c3d5..e905d94c250f 100644 --- a/.github/workflows/pr_flax_dependency_test.yml +++ b/.github/workflows/pr_flax_dependency_test.yml @@ -4,6 +4,8 @@ on: pull_request: branches: - main + paths: + - "src/diffusers/**.py" push: branches: - main diff --git a/.github/workflows/pr_quality.yml b/.github/workflows/pr_quality.yml deleted file mode 100644 index c1b58018fce1..000000000000 --- a/.github/workflows/pr_quality.yml +++ /dev/null @@ -1,49 +0,0 @@ -name: Run code quality checks - -on: - pull_request: - branches: - - main - push: - branches: - - main - -concurrency: - group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} - cancel-in-progress: true - -jobs: - check_code_quality: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - name: Set up Python - uses: actions/setup-python@v4 - with: - python-version: "3.8" - - name: Install dependencies - run: | - python -m pip install --upgrade pip - pip install .[quality] - - name: Check quality - run: | - ruff check examples tests src utils scripts - ruff format examples tests src utils scripts --check - - check_repository_consistency: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - name: Set up Python - uses: actions/setup-python@v4 - with: - python-version: "3.8" - - name: Install dependencies - run: | - python -m pip install --upgrade pip - pip install .[quality] - - name: Check quality - run: | - python utils/check_copies.py - python utils/check_dummies.py - make deps_table_check_updated diff --git a/.github/workflows/pr_test_peft_backend.yml b/.github/workflows/pr_test_peft_backend.yml index 8cc4eb6e59a9..c93e8bef40cf 100644 --- a/.github/workflows/pr_test_peft_backend.yml +++ b/.github/workflows/pr_test_peft_backend.yml @@ -4,6 +4,9 @@ on: pull_request: branches: - main + paths: + - "src/diffusers/**.py" + - "tests/**.py" concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} @@ -16,7 +19,44 @@ env: PYTEST_TIMEOUT: 60 jobs: + check_code_quality: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Set up Python + uses: actions/setup-python@v4 + with: + python-version: "3.8" + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install .[quality] + - name: Check quality + run: | + ruff check examples tests src utils scripts + ruff format examples tests src utils scripts --check + + check_repository_consistency: + needs: check_code_quality + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Set up Python + uses: actions/setup-python@v4 + with: + python-version: "3.8" + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install .[quality] + - name: Check quality + run: | + python utils/check_copies.py + python utils/check_dummies.py + make deps_table_check_updated + run_fast_tests: + needs: [check_code_quality, check_repository_consistency] strategy: fail-fast: false matrix: diff --git a/.github/workflows/pr_tests.yml b/.github/workflows/pr_tests.yml index 6693c0aa6964..d21232203479 100644 --- a/.github/workflows/pr_tests.yml +++ b/.github/workflows/pr_tests.yml @@ -4,6 +4,14 @@ on: pull_request: branches: - main + paths: + - "src/diffusers/**.py" + - "benchmarks/**.py" + - "examples/**.py" + - "scripts/**.py" + - "tests/**.py" + - ".github/**.yml" + - "utils/**.py" push: branches: - ci-* @@ -19,7 +27,44 @@ env: PYTEST_TIMEOUT: 60 jobs: + check_code_quality: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Set up Python + uses: actions/setup-python@v4 + with: + python-version: "3.8" + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install .[quality] + - name: Check quality + run: | + ruff check examples tests src utils scripts + ruff format examples tests src utils scripts --check + + check_repository_consistency: + needs: check_code_quality + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Set up Python + uses: actions/setup-python@v4 + with: + python-version: "3.8" + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install .[quality] + - name: Check quality + run: | + python utils/check_copies.py + python utils/check_dummies.py + make deps_table_check_updated + run_fast_tests: + needs: [check_code_quality, check_repository_consistency] strategy: fail-fast: false matrix: @@ -117,6 +162,7 @@ jobs: path: reports run_staging_tests: + needs: [check_code_quality, check_repository_consistency] strategy: fail-fast: false matrix: diff --git a/.github/workflows/pr_torch_dependency_test.yml b/.github/workflows/pr_torch_dependency_test.yml index 57a7a5c77c74..c8aeb4b2a6fc 100644 --- a/.github/workflows/pr_torch_dependency_test.yml +++ b/.github/workflows/pr_torch_dependency_test.yml @@ -4,6 +4,8 @@ on: pull_request: branches: - main + paths: + - "src/diffusers/**.py" push: branches: - main diff --git a/.github/workflows/push_tests.yml b/.github/workflows/push_tests.yml index 312d3ec22791..d64e24ed4209 100644 --- a/.github/workflows/push_tests.yml +++ b/.github/workflows/push_tests.yml @@ -4,7 +4,10 @@ on: push: branches: - main - + paths: + - "src/diffusers/**.py" + - "examples/**.py" + - "tests/**.py" env: DIFFUSERS_IS_CI: yes diff --git a/.github/workflows/push_tests_fast.yml b/.github/workflows/push_tests_fast.yml index 2f69b00af982..664c9732290b 100644 --- a/.github/workflows/push_tests_fast.yml +++ b/.github/workflows/push_tests_fast.yml @@ -4,6 +4,10 @@ on: push: branches: - main + paths: + - "src/diffusers/**.py" + - "examples/**.py" + - "tests/**.py" concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} diff --git a/.github/workflows/push_tests_mps.yml b/.github/workflows/push_tests_mps.yml index bdea0b760b26..76c9a0f9663e 100644 --- a/.github/workflows/push_tests_mps.yml +++ b/.github/workflows/push_tests_mps.yml @@ -4,6 +4,9 @@ on: push: branches: - main + paths: + - "src/diffusers/**.py" + - "tests/**.py" env: DIFFUSERS_IS_CI: yes