From e9c24f691c679030843ac14cb0c41debb9e0a62c Mon Sep 17 00:00:00 2001 From: SBrandeis Date: Wed, 23 Apr 2025 19:08:03 +0200 Subject: [PATCH 1/3] use the precomputed adapterWeightsPath property --- .../src/lib/getInferenceProviderMapping.ts | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/packages/inference/src/lib/getInferenceProviderMapping.ts b/packages/inference/src/lib/getInferenceProviderMapping.ts index d897cb72a0..e5f02fd257 100644 --- a/packages/inference/src/lib/getInferenceProviderMapping.ts +++ b/packages/inference/src/lib/getInferenceProviderMapping.ts @@ -8,7 +8,7 @@ import { typedInclude } from "../utils/typedInclude"; export const inferenceProviderMappingCache = new Map(); export type InferenceProviderMapping = Partial< - Record> + Record> >; export interface InferenceProviderModelMapping { @@ -75,20 +75,12 @@ export async function getInferenceProviderMapping( ); } if (providerMapping.adapter === "lora") { - const treeResp = await (options?.fetch ?? fetch)(`${HF_HUB_URL}/api/models/${params.modelId}/tree/main`); - if (!treeResp.ok) { - throw new Error(`Unable to fetch the model tree for ${params.modelId}.`); - } - const tree: Array<{ type: "file" | "directory"; path: string }> = await treeResp.json(); - const adapterWeightsPath = tree.find(({ type, path }) => type === "file" && path.endsWith(".safetensors"))?.path; - if (!adapterWeightsPath) { - throw new Error(`No .safetensors file found in the model tree for ${params.modelId}.`); - } return { ...providerMapping, hfModelId: params.modelId, - adapterWeightsPath, + adapterWeightsPath: providerMapping.adapterWeightsPath, }; + } return { ...providerMapping, hfModelId: params.modelId }; } From 2dde80c131def448c88b51f11454dd592df974de Mon Sep 17 00:00:00 2001 From: SBrandeis Date: Thu, 24 Apr 2025 15:53:19 +0200 Subject: [PATCH 2/3] actually we can remove this code wholly --- packages/inference/src/lib/getInferenceProviderMapping.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/packages/inference/src/lib/getInferenceProviderMapping.ts b/packages/inference/src/lib/getInferenceProviderMapping.ts index e5f02fd257..df138801b2 100644 --- a/packages/inference/src/lib/getInferenceProviderMapping.ts +++ b/packages/inference/src/lib/getInferenceProviderMapping.ts @@ -74,14 +74,6 @@ export async function getInferenceProviderMapping( `Model ${params.modelId} is in staging mode for provider ${params.provider}. Meant for test purposes only.` ); } - if (providerMapping.adapter === "lora") { - return { - ...providerMapping, - hfModelId: params.modelId, - adapterWeightsPath: providerMapping.adapterWeightsPath, - }; - - } return { ...providerMapping, hfModelId: params.modelId }; } return null; From 9be192ec7516a928936c408fbae9816cb5b81324 Mon Sep 17 00:00:00 2001 From: SBrandeis Date: Thu, 24 Apr 2025 15:55:45 +0200 Subject: [PATCH 3/3] remove duplicated code --- packages/inference/src/providers/fal-ai.ts | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/packages/inference/src/providers/fal-ai.ts b/packages/inference/src/providers/fal-ai.ts index c02fe831d4..83f19d287e 100644 --- a/packages/inference/src/providers/fal-ai.ts +++ b/packages/inference/src/providers/fal-ai.ts @@ -86,16 +86,6 @@ export class FalAITextToImageTask extends FalAITask implements TextToImageTaskHe ...(params.args.parameters as Record), sync_mode: true, prompt: params.args.inputs, - ...(params.mapping?.adapter === "lora" && params.mapping.adapterWeightsPath - ? { - loras: [ - { - path: buildLoraPath(params.mapping.hfModelId, params.mapping.adapterWeightsPath), - scale: 1, - }, - ], - } - : undefined), }; if (params.mapping?.adapter === "lora" && params.mapping.adapterWeightsPath) {