Skip to content

Commit f419d74

Browse files
authored
Merge pull request kubernetes-csi#40 from msau42/add-1.16
Add new variables for 1.16 and remove 1.13
2 parents adf00fe + e0fde8c commit f419d74

File tree

1 file changed

+10
-28
lines changed

1 file changed

+10
-28
lines changed

prow.sh

+10-28
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ configvar CSI_PROW_GO_VERSION_GINKGO "${CSI_PROW_GO_VERSION_BUILD}" "Go version
101101
# kind version to use. If the pre-installed version is different,
102102
# the desired version is downloaded from https://github.com/kubernetes-sigs/kind/releases/download/
103103
# (if available), otherwise it is built from source.
104-
configvar CSI_PROW_KIND_VERSION "v0.5.0" "kind"
104+
# TODO: https://github.com/kubernetes-csi/csi-release-tools/issues/39
105+
configvar CSI_PROW_KIND_VERSION "86bc23d84ac12dcb56a0528890736e2c347c2dc3" "kind"
105106

106107
# ginkgo test runner version to use. If the pre-installed version is
107108
# different, the desired version is built from source.
@@ -136,7 +137,6 @@ configvar CSI_PROW_KUBERNETES_VERSION 1.15.3 "Kubernetes"
136137
#
137138
# If the version is prefixed with "release-", then nothing
138139
# is overridden.
139-
override_k8s_version "1.13.10"
140140
override_k8s_version "1.14.6"
141141
override_k8s_version "1.15.3"
142142

@@ -183,7 +183,7 @@ configvar CSI_PROW_WORK "$(mkdir -p "$GOPATH/pkg" && mktemp -d "$GOPATH/pkg/csip
183183
#
184184
# When no deploy script is found (nothing in `deploy` directory,
185185
# CSI_PROW_HOSTPATH_REPO=none), nothing gets deployed.
186-
configvar CSI_PROW_HOSTPATH_VERSION "v1.2.0-rc8" "hostpath driver"
186+
configvar CSI_PROW_HOSTPATH_VERSION "v1.2.0" "hostpath driver"
187187
configvar CSI_PROW_HOSTPATH_REPO https://github.com/kubernetes-csi/csi-driver-host-path "hostpath repo"
188188
configvar CSI_PROW_DEPLOYMENT "" "deployment"
189189
configvar CSI_PROW_HOSTPATH_DRIVER_NAME "hostpath.csi.k8s.io" "the hostpath driver name"
@@ -200,9 +200,10 @@ configvar CSI_PROW_HOSTPATH_CANARY "" "hostpath image"
200200
# all generated files are present.
201201
#
202202
# CSI_PROW_E2E_REPO=none disables E2E testing.
203-
configvar CSI_PROW_E2E_VERSION_1_13 v1.14.0 "E2E version for Kubernetes 1.13.x" # we can't use the one from 1.13.x because it didn't have --storage.testdriver
203+
# TOOO: remove versioned variables and make e2e version match k8s version
204204
configvar CSI_PROW_E2E_VERSION_1_14 v1.14.0 "E2E version for Kubernetes 1.14.x"
205205
configvar CSI_PROW_E2E_VERSION_1_15 v1.15.0 "E2E version for Kubernetes 1.15.x"
206+
configvar CSI_PROW_E2E_VERSION_1_16 v1.16.0 "E2E version for Kubernetes 1.16.x"
206207
# TODO: add new CSI_PROW_E2E_VERSION entry for future Kubernetes releases
207208
configvar CSI_PROW_E2E_VERSION_LATEST master "E2E version for Kubernetes master" # testing against Kubernetes master is already tracking a moving target, so we might as well use a moving E2E version
208209
configvar CSI_PROW_E2E_REPO_LATEST https://github.com/kubernetes/kubernetes "E2E repo for Kubernetes >= 1.13.x" # currently the same for all versions
@@ -292,11 +293,6 @@ regex_join () {
292293
# alpha in previous Kubernetes releases. This was considered too
293294
# error prone. Therefore we use E2E tests that match the Kubernetes
294295
# version that is getting tested.
295-
#
296-
# However, for 1.13.x testing we have to use the E2E tests from 1.14
297-
# because 1.13 didn't have --storage.testdriver yet, so for that (and only
298-
# that version) we have to define alpha tests differently.
299-
configvar CSI_PROW_E2E_ALPHA_1_13 '\[Feature: \[Testpattern:.Dynamic.PV..block.volmode.\] should.create.and.delete.block.persistent.volumes' "alpha tests for Kubernetes 1.13" # Raw block was an alpha feature in 1.13.
300296
configvar CSI_PROW_E2E_ALPHA_LATEST '\[Feature:' "alpha tests for Kubernetes >= 1.14" # there's no need to update this, adding a new case for CSI_PROW_E2E for a new Kubernetes is enough
301297
configvar CSI_PROW_E2E_ALPHA "$(get_versioned_variable CSI_PROW_E2E_ALPHA "${csi_prow_kubernetes_version_suffix}")" "alpha tests"
302298

@@ -312,12 +308,12 @@ configvar CSI_PROW_E2E_ALPHA "$(get_versioned_variable CSI_PROW_E2E_ALPHA "${csi
312308
# kubernetes-csi components must be updated, either by disabling
313309
# the failing test for "latest" or by updating the test and not running
314310
# it anymore for older releases.
315-
configvar CSI_PROW_E2E_ALPHA_GATES_1_13 'VolumeSnapshotDataSource=true,BlockVolume=true,CSIBlockVolume=true' "alpha feature gates for Kubernetes 1.13"
316311
configvar CSI_PROW_E2E_ALPHA_GATES_1_14 'VolumeSnapshotDataSource=true,ExpandCSIVolumes=true' "alpha feature gates for Kubernetes 1.14"
317312
configvar CSI_PROW_E2E_ALPHA_GATES_1_15 'VolumeSnapshotDataSource=true,ExpandCSIVolumes=true' "alpha feature gates for Kubernetes 1.15"
313+
configvar CSI_PROW_E2E_ALPHA_GATES_1_16 'VolumeSnapshotDataSource=true' "alpha feature gates for Kubernetes 1.16"
318314
# TODO: add new CSI_PROW_ALPHA_GATES_xxx entry for future Kubernetes releases and
319315
# add new gates to CSI_PROW_E2E_ALPHA_GATES_LATEST.
320-
configvar CSI_PROW_E2E_ALPHA_GATES_LATEST 'VolumeSnapshotDataSource=true,ExpandCSIVolumes=true' "alpha feature gates for latest Kubernetes"
316+
configvar CSI_PROW_E2E_ALPHA_GATES_LATEST 'VolumeSnapshotDataSource=true' "alpha feature gates for latest Kubernetes"
321317
configvar CSI_PROW_E2E_ALPHA_GATES "$(get_versioned_variable CSI_PROW_E2E_ALPHA_GATES "${csi_prow_kubernetes_version_suffix}")" "alpha E2E feature gates"
322318

323319
# Some tests are known to be unusable in a KinD cluster. For example,
@@ -723,22 +719,6 @@ install_sanity () (
723719
run_with_go "${CSI_PROW_GO_VERSION_SANITY}" go test -c -o "${CSI_PROW_WORK}/csi-sanity" "${CSI_PROW_SANITY_IMPORT_PATH}/cmd/csi-sanity" || die "building csi-sanity failed"
724720
)
725721

726-
# Whether the hostpath driver supports raw block devices depends on which version
727-
# we are testing. It would be much nicer if we could determine that by querying the
728-
# installed driver's capabilities instead of having to do a version check.
729-
hostpath_supports_block () {
730-
local result
731-
result="$(docker exec csi-prow-control-plane docker image ls --format='{{.Repository}} {{.Tag}} {{.ID}}' | grep hostpath | while read -r repo tag id; do
732-
if [ "$tag" == "v1.0.1" ]; then
733-
# Old version because the revision label is missing: didn't have support yet.
734-
echo "false"
735-
return
736-
fi
737-
done)"
738-
# If not set, then it must be a newer driver with support.
739-
echo "${result:-true}"
740-
}
741-
742722
# The default implementation of this function generates a external
743723
# driver test configuration for the hostpath driver.
744724
#
@@ -755,12 +735,14 @@ SnapshotClass:
755735
DriverInfo:
756736
Name: ${CSI_PROW_HOSTPATH_DRIVER_NAME}
757737
Capabilities:
758-
block: $(hostpath_supports_block)
738+
block: true
759739
persistence: true
760740
dataSource: true
761741
multipods: true
762742
nodeExpansion: true
763743
controllerExpansion: true
744+
snapshotDataSource: true
745+
singleNodeVolume: true
764746
EOF
765747
}
766748

0 commit comments

Comments
 (0)