Skip to content
This repository was archived by the owner on Feb 8, 2021. It is now read-only.

Commit 9d48e6b

Browse files
authored
Merge pull request #264 from Jimmy-Xu/fix-test-case
fix-test-case
2 parents ba006bf + 5cc967b commit 9d48e6b

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

Diff for: integration-cli/hyper_cli_load_basic_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func (s *DockerSuite) TestCliLoadFromUrlInvalidUrlPath(c *check.C) {
4040
testRequires(c, DaemonIsLinux)
4141

4242
output, exitCode, err := dockerCmdWithError("load", "-i", "http://image-tarball.s3.amazonaws.com/test/public/notexist.tar")
43-
c.Assert(output, checker.Equals, "Error response from daemon: Bad request parameters: Got HTTP status code >= 400: 403 Forbidden\n")
43+
c.Assert(output, checker.Equals, "Error response from daemon: Bad request parameters: Got HTTP status code >= 400: 404 Not Found\n")
4444
c.Assert(exitCode, checker.Equals, 1)
4545
c.Assert(err, checker.NotNil)
4646
}
@@ -135,7 +135,7 @@ func (s *DockerSuite) TestCliLoadFromUrlInvalidContentIncomplete(c *check.C) {
135135

136136
url = "http://image-tarball.s3.amazonaws.com/test/public/helloworld-no-layer.tgz"
137137
output, exitCode, err = dockerCmdWithError("load", "-i", url)
138-
c.Assert(output, checker.Contains, "json: no such file or directory")
138+
c.Assert(output, checker.Contains, "no such file or directory")
139139
c.Assert(exitCode, checker.Equals, 1)
140140
c.Assert(err, checker.NotNil)
141141

Diff for: integration-cli/hyper_cli_load_legacy_test.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ func (s *DockerSuite) TestCliLoadFromUrlLegacyImageArchiveFile(c *check.C) {
1212
defer printTestDuration(time.Now())
1313
testRequires(c, DaemonIsLinux)
1414

15-
imageName := "ubuntu"
16-
legacyImageURL := "http://image-tarball.s3.amazonaws.com/test/public/old/ubuntu_1.8.tar.gz"
17-
imageURL := "http://image-tarball.s3.amazonaws.com/test/public/ubuntu.tar.gz"
15+
imageName := "busybox"
16+
legacyImageURL := "http://image-tarball.s3.amazonaws.com/test/public/old/busybox_1.8.tar.gz"
17+
imageURL := "http://image-tarball.s3.amazonaws.com/test/public/busybox.tar.gz"
1818

1919
//load legacy image(saved by docker 1.8)
2020
output, exitCode, err := dockerCmdWithError("load", "-i", legacyImageURL)
@@ -37,7 +37,7 @@ func (s *DockerSuite) TestCliLoadFromUrlLegacyImageArchiveFile(c *check.C) {
3737

3838
output, _ = dockerCmd(c, "images")
3939
c.Assert(output, checker.Contains, imageName)
40-
c.Assert(len(strings.Split(output, "\n")), checker.Equals, 3)
40+
c.Assert(len(strings.Split(output, "\n")), checker.Equals, 4)
4141

4242
/////////////////////////////////////////////////////////////////////
4343
//delete single layer
@@ -56,7 +56,7 @@ func (s *DockerSuite) TestCliLoadFromUrlLegacyImageArchiveFile(c *check.C) {
5656

5757
output, _ = dockerCmd(c, "images", "-a")
5858
c.Assert(output, checker.Contains, "<none>")
59-
c.Assert(len(strings.Split(output, "\n")), checker.Equals, 6)
59+
c.Assert(len(strings.Split(output, "\n")), checker.Equals, 4)
6060

6161
/////////////////////////////////////////////////////////////////////
6262
//delete all rest layer

Diff for: integration-cli/hyper_cli_load_local_test.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,13 @@ func (s *DockerSuite) TestCliLoadFromLocalTarNoTag(c *check.C) {
8686

8787
//load image tar
8888
output, exitCode, err = dockerCmdWithError("load", "-i", imagePath)
89-
c.Assert(output, checker.Contains, "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798 has been loaded.")
89+
c.Assert(output, checker.Contains, "sha256:59788edf1f3e78cd0ebe6ce1446e9d10788225db3dedcfd1a59f764bad2b2690 has been loaded.")
9090
c.Assert(err, checker.IsNil)
9191
c.Assert(exitCode, checker.Equals, 0)
9292

9393
//check image
9494
images, _ := dockerCmd(c, "images")
95-
c.Assert(images, checker.Contains, "c75bebcdd211")
95+
c.Assert(images, checker.Contains, "59788edf1f3e")
9696
}
9797

9898
func (s *DockerSuite) TestCliLoadFromLocalTarDelta(c *check.C) {
@@ -131,8 +131,8 @@ func (s *DockerSuite) TestCliLoadFromLocalTarDelta(c *check.C) {
131131
c.Assert(exitCode, checker.Equals, 0)
132132

133133
// //check image
134-
ensureImageIDExist(c, "busybox", "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798")
135-
ensureImageIDExist(c, "busybox2", "sha256:50a48a50d85a126c96d01528bb836e62ad08555e740b44f299abf3416656bdb5")
134+
ensureImageIDExist(c, "busybox", "sha256:c30178c5239f2937c21c261b0365efcda25be4921ccb95acd63beeeb78786f27")
135+
ensureImageIDExist(c, "busybox2", "sha256:6ad733544a6317992a6fac4eb19fe1df577d4dec7529efec28a5bd0edad0fd30")
136136
}
137137

138138
func (s *DockerSuite) TestCliLoadFromLocalCompressedArchive(c *check.C) {
@@ -282,7 +282,7 @@ func (s *DockerSuite) TestCliLoadFromLocalTarLegacy(c *check.C) {
282282
defer printTestDuration(time.Now())
283283
testRequires(c, DaemonIsLinux)
284284

285-
publicURL := "http://image-tarball.s3.amazonaws.com/test/public/old/ubuntu_1.8.tar.gz"
285+
publicURL := "http://image-tarball.s3.amazonaws.com/test/public/old/busybox_1.8.tar.gz"
286286
imagePath := fmt.Sprintf("%s/ubuntu_1.8.tar.gz", os.Getenv("IMAGE_DIR"))
287287

288288
//download image tar

0 commit comments

Comments
 (0)