move other header parse utils to util module

Author: seanmonstar

common/connection.rs

@@ -1,7 +1,7 @@
 use header::{Header, HeaderFormat};
 use std::fmt::{mod, Show};
-use super::{from_comma_delimited, fmt_comma_delimited};
 use std::str::FromStr;
+use super::util::{from_comma_delimited, fmt_comma_delimited};
 
 /// The `Connection` header.
 #[deriving(Clone, PartialEq, Show)]

common/mod.rs

@@ -21,9 +21,6 @@ pub use self::user_agent::UserAgent;
 pub use self::server::Server;
 pub use self::set_cookie::SetCookie;
 
-use std::fmt::{mod, Show};
-use std::str::{FromStr, from_utf8};
-
 macro_rules! bench_header(
     ($name:ident, $ty:ty, $value:expr) => {
         #[cfg(test)]
@@ -105,30 +102,3 @@ pub mod upgrade;
 pub mod user_agent;
 
 pub mod util;
-
-fn from_comma_delimited<T: FromStr>(raw: &[Vec<u8>]) -> Option<Vec<T>> {
-    if raw.len() != 1 {
-        return None;
-    }
-    // we JUST checked that raw.len() == 1, so raw[0] WILL exist.
-    match from_utf8(unsafe { raw.as_slice().unsafe_get(0).as_slice() }) {
-        Some(s) => {
-            Some(s.as_slice()
-                 .split([',', ' '].as_slice())
-                 .filter_map(from_str)
-                 .collect())
-        }
-        None => None
-    }
-}
-
-fn fmt_comma_delimited<T: Show>(fmt: &mut fmt::Formatter, parts: &[T]) -> fmt::Result {
-    let last = parts.len() - 1;
-    for (i, part) in parts.iter().enumerate() {
-        try!(part.fmt(fmt));
-        if i < last {
-            try!(", ".fmt(fmt));
-        }
-    }
-    Ok(())
-}

common/transfer_encoding.rs

@@ -1,7 +1,7 @@
 use header::{Header, HeaderFormat};
 use std::fmt;
 use std::str::FromStr;
-use super::{from_comma_delimited, fmt_comma_delimited};
+use super::util::{from_comma_delimited, fmt_comma_delimited};
 
 /// The `Transfer-Encoding` header.
 ///

common/upgrade.rs

@@ -1,7 +1,7 @@
 use header::{Header, HeaderFormat};
 use std::fmt::{mod, Show};
-use super::{from_comma_delimited, fmt_comma_delimited};
 use std::str::FromStr;
+use super::util::{from_comma_delimited, fmt_comma_delimited};
 
 /// The `Upgrade` header.
 #[deriving(Clone, PartialEq, Show)]

common/util.rs

@@ -1,8 +1,9 @@
 //! Utility functions for Header implementations.
 
 use std::str::{FromStr, from_utf8};
+use std::fmt::{mod, Show};
 
-/// Utility function that reads a single raw string when parsing a header
+/// Reads a single raw string when parsing a header
 pub fn from_one_raw_str<T: FromStr>(raw: &[Vec<u8>]) -> Option<T> {
     if raw.len() != 1 {
         return None;
@@ -13,3 +14,32 @@ pub fn from_one_raw_str<T: FromStr>(raw: &[Vec<u8>]) -> Option<T> {
         None => None
     }
 }
+
+/// Reads a comma-delimited raw string into a Vec.
+pub fn from_comma_delimited<T: FromStr>(raw: &[Vec<u8>]) -> Option<Vec<T>> {
+    if raw.len() != 1 {
+        return None;
+    }
+    // we JUST checked that raw.len() == 1, so raw[0] WILL exist.
+    match from_utf8(unsafe { raw.as_slice().unsafe_get(0).as_slice() }) {
+        Some(s) => {
+            Some(s.as_slice()
+                 .split([',', ' '].as_slice())
+                 .filter_map(from_str)
+                 .collect())
+        }
+        None => None
+    }
+}
+
+/// Format an array into a comma-delimited string.
+pub fn fmt_comma_delimited<T: Show>(fmt: &mut fmt::Formatter, parts: &[T]) -> fmt::Result {
+    let last = parts.len() - 1;
+    for (i, part) in parts.iter().enumerate() {
+        try!(part.fmt(fmt));
+        if i < last {
+            try!(", ".fmt(fmt));
+        }
+    }
+    Ok(())
+}