Skip to content

Commit 5db8531

Browse files
committed
refactor(client): replace signal mod with want crate
1 parent 06f0126 commit 5db8531

File tree

5 files changed

+7
-195
lines changed

5 files changed

+7
-195
lines changed

Cargo.toml

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ tokio = "0.1.3"
3535
tokio-executor = "0.1.0"
3636
tokio-service = "0.1"
3737
tokio-io = "0.1"
38+
want = "0.0.2"
3839

3940
[dev-dependencies]
4041
num_cpus = "1.0"

src/client/dispatch.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
use futures::{Async, Poll, Stream};
22
use futures::sync::{mpsc, oneshot};
3+
use want;
34

45
use common::Never;
5-
use super::signal;
66

77
//pub type Callback<T, U> = oneshot::Sender<Result<U, (::Error, Option<T>)>>;
88
pub type RetryPromise<T, U> = oneshot::Receiver<Result<U, (::Error, Option<T>)>>;
99
pub type Promise<T> = oneshot::Receiver<Result<T, ::Error>>;
1010

1111
pub fn channel<T, U>() -> (Sender<T, U>, Receiver<T, U>) {
1212
let (tx, rx) = mpsc::channel(0);
13-
let (giver, taker) = signal::new();
13+
let (giver, taker) = want::new();
1414
let tx = Sender {
1515
giver: giver,
1616
inner: tx,
@@ -27,7 +27,7 @@ pub struct Sender<T, U> {
2727
// when the queue is empty. This helps us know when a request and
2828
// response have been fully processed, and a connection is ready
2929
// for more.
30-
giver: signal::Giver,
30+
giver: want::Giver,
3131
//inner: mpsc::Sender<(T, Callback<T, U>)>,
3232
inner: mpsc::Sender<Envelope<T, U>>,
3333
}
@@ -68,7 +68,7 @@ impl<T, U> Sender<T, U> {
6868
pub struct Receiver<T, U> {
6969
//inner: mpsc::Receiver<(T, Callback<T, U>)>,
7070
inner: mpsc::Receiver<Envelope<T, U>>,
71-
taker: signal::Taker,
71+
taker: want::Taker,
7272
}
7373

7474
impl<T, U> Stream for Receiver<T, U> {
@@ -229,7 +229,7 @@ mod tests {
229229
#[cfg(feature = "nightly")]
230230
#[bench]
231231
fn giver_queue_cancel(b: &mut test::Bencher) {
232-
let (_tx, rx) = super::channel::<i32, ()>();
232+
let (_tx, mut rx) = super::channel::<i32, ()>();
233233

234234
b.iter(move || {
235235
rx.taker.cancel();

src/client/mod.rs

-2
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,9 @@ use self::connect::Destination;
2626

2727
pub mod conn;
2828
pub mod connect;
29-
//TODO(easy): move cancel and dispatch into common instead
3029
pub(crate) mod dispatch;
3130
mod dns;
3231
mod pool;
33-
mod signal;
3432
#[cfg(test)]
3533
mod tests;
3634

src/client/signal.rs

-188
This file was deleted.

src/lib.rs

+1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ extern crate tokio;
3030
extern crate tokio_executor;
3131
#[macro_use] extern crate tokio_io;
3232
extern crate tokio_service;
33+
extern crate want;
3334

3435
#[cfg(all(test, feature = "nightly"))]
3536
extern crate test;

0 commit comments

Comments
 (0)