Ensure all overloads of SWBBuildService.createSession pass along the developerPath parameter. (swiftlang#293)

cwakamo · web-flow · commit 791107506522 · 2025-03-11T22:51:47.000-07:00
Without this, clients which use a deprecated createSession overload fail to find the Developer directory during initialization. This fixes swiftlang#292.
diff --git a/Sources/SwiftBuild/SWBBuildService.swift b/Sources/SwiftBuild/SWBBuildService.swift
@@ -196,7 +196,7 @@ public final class SWBBuildService: Sendable {
 
     // ABI compatibility
     public func createSession(name: String, developerPath: String? = nil, cachePath: String?, inferiorProductsPath: String?, environment: [String:String]?) async -> (Result<SWBBuildServiceSession, any Error>, [SwiftBuildMessage.DiagnosticInfo]) {
-        await createSession(name: name, resourceSearchPaths: [], cachePath: cachePath, inferiorProductsPath: inferiorProductsPath, environment: environment)
+        await createSession(name: name, developerPath: developerPath, resourceSearchPaths: [], cachePath: cachePath, inferiorProductsPath: inferiorProductsPath, environment: environment)
     }
 
     /// Create a new service session.

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ public final class SWBBuildService: Sendable {`
`196`	`196`
`197`	`197`	`// ABI compatibility`
`198`	`198`	`public func createSession(name: String, developerPath: String? = nil, cachePath: String?, inferiorProductsPath: String?, environment: [String:String]?) async -> (Result<SWBBuildServiceSession, any Error>, [SwiftBuildMessage.DiagnosticInfo]) {`
`199`		`- await createSession(name: name, resourceSearchPaths: [], cachePath: cachePath, inferiorProductsPath: inferiorProductsPath, environment: environment)`
	`199`	`+ await createSession(name: name, developerPath: developerPath, resourceSearchPaths: [], cachePath: cachePath, inferiorProductsPath: inferiorProductsPath, environment: environment)`
`200`	`200`	`}`
`201`	`201`
`202`	`202`	`/// Create a new service session.`