Skip to content

feat(uuid): support uuid v6 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2020
Merged

feat(uuid): support uuid v6 #181

merged 3 commits into from
Aug 3, 2020

Conversation

intech
Copy link
Contributor

@intech intech commented Jul 31, 2020

Added support for uuid v6, which is a modified version from uuid v1 with lexicographic order for sorting.
Ref: https://www.npmjs.com/package/uuid-v6

intech added 2 commits July 31, 2020 09:38
feat(uuid): support uuid v6
feat(uuid): support uuid v6
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.577% when pulling 64b7b88 on intech:master into 34552f2 on icebob:master.

@erfanium erfanium requested review from icebob and erfanium July 31, 2020 08:43
Copy link
Collaborator

@erfanium erfanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, But please add a test for this feature

feat(uuid): support uuid v6
@intech intech requested a review from erfanium July 31, 2020 09:08
@intech
Copy link
Contributor Author

intech commented Jul 31, 2020

@erfanium done

Copy link
Collaborator

@erfanium erfanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Owner

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@icebob icebob merged commit 437bb55 into icebob:master Aug 3, 2020
@icebob
Copy link
Owner

icebob commented Aug 3, 2020

@intech
Copy link
Contributor Author

intech commented Aug 3, 2020

@intech one moment

@intech intech mentioned this pull request Aug 3, 2020
@intech
Copy link
Contributor Author

intech commented Aug 3, 2020

@icebob done. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants