Skip to content

Commit b821700

Browse files
committed
2 parents 4707550 + 430cc7f commit b821700

File tree

4 files changed

+18
-15
lines changed

4 files changed

+18
-15
lines changed

.github/workflows/node.js.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
steps:
3131
- uses: actions/checkout@v2
3232
- name: Use Node.js ${{ matrix.node-version }}
33-
uses: actions/setup-node@v1
33+
uses: actions/setup-node@v2.1.5
3434
with:
3535
node-version: ${{ matrix.node-version }}
3636
- run: npm ci

Readme.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,7 @@ false instanceof Chess.Color // true
9595
1 instanceof Chess.PieceType // true
9696
59 instanceof Chess.Square // true
9797

98-
// NOTE: I can't use BigInt to represent 'int' in python,
99-
// because in Python squares can be used as an index,
100-
// and in javascript, you can't use BigInt to index arrays
98+
// NOTE: I'm not using BigInt to represent 'int' in python
10199
Chess.isSquare(10n) // false
102100
Chess.isSquare(10) // true
103101
Chess.isSquare(3858) // "out of range"
@@ -113,7 +111,9 @@ Some other notes about types:
113111

114112
* ```None``` corresponds to ```null```
115113
* ```chess.Status is an Enum``` in python, but that's Really Really hard to implement exactly
116-
* Enums can't be pickled or unpickled
114+
* In python is IntFlag Enum subclasses both Int and Enum.
115+
* And the prototype chain makes that impossible without modifying Number.
116+
* Enums can't be pickled or unpickled - doesn't make sense here
117117

118118
### Developer notes
119119

package-lock.json

Lines changed: 8 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,18 @@
1818
"license": "GPL-3.0-or-later",
1919
"dependencies": {
2020
"@types/jest": "^26.0.20",
21-
"@typescript-eslint/eslint-plugin": "^4.15.1",
22-
"@typescript-eslint/parser": "^4.15.1",
23-
"eslint": "^7.20.0",
21+
"@typescript-eslint/eslint-plugin": "^4.16.1",
22+
"@typescript-eslint/parser": "^4.16.1",
23+
"eslint": "^7.21.0",
2424
"eslint-config-standard-with-typescript": "^20.0.0",
2525
"eslint-plugin-import": "^2.22.1",
2626
"eslint-plugin-jest": "^24.1.3",
2727
"eslint-plugin-node": "^11.1.0",
2828
"eslint-plugin-promise": "^4.3.1",
2929
"jest": "^26.6.3",
30-
"ts-jest": "^26.5.1",
30+
"ts-jest": "^26.5.3",
3131
"ts-node": "^9.1.1",
32-
"typescript": "^4.1.5"
32+
"typescript": "^4.2.3"
3333
},
3434
"devDependencies": {
3535
"chalk": "^4.1.0",

0 commit comments

Comments
 (0)