File tree 4 files changed +18
-15
lines changed 4 files changed +18
-15
lines changed Original file line number Diff line number Diff line change 30
30
steps :
31
31
- uses : actions/checkout@v2
32
32
- name : Use Node.js ${{ matrix.node-version }}
33
- uses : actions/setup-node@v1
33
+ uses : actions/setup-node@v2.1.5
34
34
with :
35
35
node-version : ${{ matrix.node-version }}
36
36
- run : npm ci
Original file line number Diff line number Diff line change @@ -95,9 +95,7 @@ false instanceof Chess.Color // true
95
95
1 instanceof Chess .PieceType // true
96
96
59 instanceof Chess .Square // true
97
97
98
- // NOTE: I can't use BigInt to represent 'int' in python,
99
- // because in Python squares can be used as an index,
100
- // and in javascript, you can't use BigInt to index arrays
98
+ // NOTE: I'm not using BigInt to represent 'int' in python
101
99
Chess .isSquare (10n ) // false
102
100
Chess .isSquare (10 ) // true
103
101
Chess .isSquare (3858 ) // "out of range"
@@ -113,7 +111,9 @@ Some other notes about types:
113
111
114
112
* ``` None ``` corresponds to ``` null ```
115
113
* ``` chess.Status is an Enum ``` in python, but that's Really Really hard to implement exactly
116
- * Enums can't be pickled or unpickled
114
+ * In python is IntFlag Enum subclasses both Int and Enum.
115
+ * And the prototype chain makes that impossible without modifying Number.
116
+ * Enums can't be pickled or unpickled - doesn't make sense here
117
117
118
118
### Developer notes
119
119
Original file line number Diff line number Diff line change 18
18
"license" : " GPL-3.0-or-later" ,
19
19
"dependencies" : {
20
20
"@types/jest" : " ^26.0.20" ,
21
- "@typescript-eslint/eslint-plugin" : " ^4.15 .1" ,
22
- "@typescript-eslint/parser" : " ^4.15 .1" ,
23
- "eslint" : " ^7.20 .0" ,
21
+ "@typescript-eslint/eslint-plugin" : " ^4.16 .1" ,
22
+ "@typescript-eslint/parser" : " ^4.16 .1" ,
23
+ "eslint" : " ^7.21 .0" ,
24
24
"eslint-config-standard-with-typescript" : " ^20.0.0" ,
25
25
"eslint-plugin-import" : " ^2.22.1" ,
26
26
"eslint-plugin-jest" : " ^24.1.3" ,
27
27
"eslint-plugin-node" : " ^11.1.0" ,
28
28
"eslint-plugin-promise" : " ^4.3.1" ,
29
29
"jest" : " ^26.6.3" ,
30
- "ts-jest" : " ^26.5.1 " ,
30
+ "ts-jest" : " ^26.5.3 " ,
31
31
"ts-node" : " ^9.1.1" ,
32
- "typescript" : " ^4.1.5 "
32
+ "typescript" : " ^4.2.3 "
33
33
},
34
34
"devDependencies" : {
35
35
"chalk" : " ^4.1.0" ,
You can’t perform that action at this time.
0 commit comments