Skip to content

Breaking changes from v0.1.3 to v2.0.0? #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joelmukuthu opened this issue Jul 18, 2018 · 4 comments
Closed

Breaking changes from v0.1.3 to v2.0.0? #22

joelmukuthu opened this issue Jul 18, 2018 · 4 comments

Comments

@joelmukuthu
Copy link

Hi,

I'm using this module and looking to upgrade from 0.1.3 to 2.0.0 but can't determine what the breaking changes were. What were they?

Thanks,
Joel

@clayzermk1
Copy link

I'd like to second this request, and give this a bump since it's been ~6mo with no reply. Could a maintainer please update the release information?

@monteslu
Copy link
Member

thanks for the reminder @clayzermk1 I somehow missed the issue when it was created.

I sort of inherited this module a while back and wasn't 100% certain the last 4 PRs weren't breaking changes. Had a few people asking for a new published version, so I bumped the major just to be 100% sure not to break anyone using 1.x

@clayzermk1
Copy link

Thanks for maintaining this critical package!

Bumping the major was certainly a prudent thing to do.

From what I can see, there never was a 1.x release, only 0.x releases. pg itself is still using 0.1.3. The releases page doesn't show any releases between 0.1.3 and 2.0.0. semver.npmjs.com doesn't show any 1.x releases either.

Would you have time to review the 10 commits between 0.1.3 and 2.0.0, move up the "latest release" flag, and update the 2.0.0 release description with a summary of the changes? I looked them over in detail and they seem to be straightforward. I could even take a stab at a changelog draft in the issue here.

@hjr3
Copy link
Contributor

hjr3 commented May 23, 2019

https://github.com/iceddev/pg-connection-string/releases/tag/v2.0.0

Please review and let me know if I missed anything: v0.1.3...v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants