SonarQube comments addressed

Author: naman-sriv

microservices-self-registration/contextservice/src/main/java/com/learning/contextservice/controller/ContextController.java

@@ -9,11 +9,14 @@
 @RestController
 public class ContextController {
 
-  @Autowired
-  private GreetingServiceClient greetingServiceClient;
+  private final GreetingServiceClient greetingServiceClient;
+  private final String userRegion;
 
-  @Value("${user.region}")
-  private String userRegion;
+  @Autowired
+  public ContextController(GreetingServiceClient greetingServiceClient, @Value("${user.region}") String userRegion) {
+    this.greetingServiceClient = greetingServiceClient;
+    this.userRegion = userRegion;
+  }
 
   @GetMapping("/context")
   public String getContext() {

microservices-self-registration/contextservice/src/test/java/com/learning/contextservice/ContextControllerTest.java

@@ -2,23 +2,19 @@
 
 import com.learning.contextservice.client.GreetingServiceClient;
 import com.learning.contextservice.controller.ContextController;
-import com.netflix.discovery.converters.Auto;
 import org.junit.jupiter.api.Test;
-import org.mockito.Mock;
 import org.mockito.Mockito;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
-import org.springframework.cloud.openfeign.FeignAutoConfiguration;
-import org.springframework.context.annotation.Import;
 import org.springframework.http.MediaType;
 import org.springframework.test.context.bean.override.mockito.MockitoBean;
 import org.springframework.test.web.servlet.MockMvc;
 import org.springframework.test.web.servlet.request.MockMvcRequestBuilders;
 import org.springframework.test.web.servlet.result.MockMvcResultMatchers;
 
 @WebMvcTest(ContextController.class)
-public class ContextControllerTest {
+class ContextControllerTest {
 
   @Autowired
   private MockMvc mockMvc;

microservices-self-registration/contextservice/src/test/java/com/learning/contextservice/ContextserviceApplicationTests.java

@@ -8,6 +8,10 @@ class ContextserviceApplicationTests {
 
 	@Test
 	void contextLoads() {
+    // This is a basic integration test that checks if the Spring Application Context loads successfully.
+    // If the context loads without any exceptions, the test is considered passing.
+    // It is often left empty as the act of loading the context is the primary verification.
+    // You can add specific assertions here if you want to verify the presence or state of certain beans.
 	}
 
 }

microservices-self-registration/eurekaserver/src/test/java/com/learning/eurekaserver/EurekaserverApplicationTests.java

@@ -8,6 +8,10 @@ class EurekaserverApplicationTests {
 
 	@Test
 	void contextLoads() {
+    // This is a basic integration test that checks if the Spring Application Context loads successfully.
+    // If the context loads without any exceptions, the test is considered passing.
+    // It is often left empty as the act of loading the context is the primary verification.
+    // You can add specific assertions here if you want to verify the presence or state of certain beans.
 	}
 
 }

microservices-self-registration/greetingservice/src/test/java/com/learning/greetingservice/GreetingControllerTest.java

@@ -9,7 +9,7 @@
 import org.springframework.test.web.servlet.result.MockMvcResultMatchers;
 
 @WebMvcTest(GreetingsController.class)
-public class GreetingControllerTest {
+class GreetingControllerTest {
 
   @Autowired
   private MockMvc mockMvc;

microservices-self-registration/greetingservice/src/test/java/com/learning/greetingservice/GreetingserviceApplicationTests.java

@@ -8,6 +8,10 @@ class GreetingserviceApplicationTests {
 
 	@Test
 	void contextLoads() {
+    // This is a basic integration test that checks if the Spring Application Context loads successfully.
+    // If the context loads without any exceptions, the test is considered passing.
+    // It is often left empty as the act of loading the context is the primary verification.
+    // You can add specific assertions here if you want to verify the presence or state of certain beans.
 	}
 
 }

pom.xml

@@ -166,7 +166,7 @@
     <module>microservices-distributed-tracing</module>
     <module>microservices-idempotent-consumer</module>
     <module>microservices-log-aggregation</module>
-    <module>microservices-self-registration-registration</module>
+    <module>microservices-self-registration</module>
     <module>model-view-controller</module>
     <module>model-view-intent</module>
     <module>model-view-presenter</module>