Skip to content

Commit 03225eb

Browse files
Update coding style, documentation
1 parent d4bed97 commit 03225eb

File tree

3 files changed

+19
-21
lines changed

3 files changed

+19
-21
lines changed

Diff for: docs/rules/group-exports.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,17 @@ This rule warns whenever a single file contains multiple named exports or assign
1111
### Valid
1212

1313
```js
14-
// Default export is adjacent to named export -> ok
14+
// Default export statement is adjacent to named export -> ok
1515
export default function test() {}
16-
// A single named export -> ok
16+
// A single named export statement -> ok
1717
export const valid = true
1818
```
1919

2020
```js
2121
const first = true
2222
const second = true
2323

24-
// A single named export -> ok
24+
// A single named export statement -> ok
2525
export {
2626
first,
2727
second,
@@ -39,13 +39,13 @@ module.exports = {
3939
### Invalid
4040

4141
```js
42-
// Multiple named exports -> not ok!
42+
// Multiple named export statements -> not ok!
4343
export const first = true
4444
export const second = true
4545
```
4646

4747
```js
48-
// Default export is not adjacent to the named export -> not ok!
48+
// Default export is not adjacent to the named export statement -> not ok!
4949
export default {}
5050
const first = true
5151
export { first }

Diff for: src/rules/group-exports.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
const meta = {}
2+
/* eslint-disable max-len */
23
const errors = {
3-
ExportNamedDeclaration:
4-
'Multiple named export declarations; consolidate all named exports into a single statement',
5-
ExportDefaultDeclaration:
6-
'Default export declaration should be adjacent to named export',
7-
MemberExpression:
8-
'Multiple CommonJS exports; consolidate all exports into a single assignment to ' +
9-
'`module.exports`',
4+
ExportNamedDeclaration: 'Multiple named export declarations; consolidate all named exports into a single statement',
5+
ExportDefaultDeclaration: 'Default export declaration should be adjacent to named export',
6+
MemberExpression: 'Multiple CommonJS exports; consolidate all exports into a single assignment to `module.exports`',
107
}
8+
/* eslint-enable max-len */
119

1210
/**
1311
* Check if two nodes are adjacent (only whitespace between them)
@@ -85,7 +83,8 @@ function create(context) {
8583
return
8684
}
8785

88-
return void exports.named.add(node)
86+
exports.named.add(node)
87+
return
8988
}
9089

9190
if (node.object.name === 'exports') {
@@ -94,7 +93,8 @@ function create(context) {
9493
return
9594
}
9695

97-
return void exports.named.add(node)
96+
exports.named.add(node)
97+
return
9898
}
9999
},
100100

Diff for: tests/src/rules/group-exports.js

+5-7
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,13 @@ import { test } from '../utils'
22
import { RuleTester } from 'eslint'
33
import rule from 'rules/group-exports'
44

5+
/* eslint-disable max-len */
56
const errors = {
6-
named:
7-
'Multiple named export declarations; consolidate all named exports into a single statement',
8-
default:
9-
'Default export declaration should be adjacent to named export',
10-
commonjs:
11-
'Multiple CommonJS exports; consolidate all exports into a single assignment to ' +
12-
'`module.exports`',
7+
named: 'Multiple named export declarations; consolidate all named exports into a single statement',
8+
default: 'Default export declaration should be adjacent to named export',
9+
commonjs: 'Multiple CommonJS exports; consolidate all exports into a single assignment to `module.exports`',
1310
}
11+
/* eslint-enable max-len */
1412
const ruleTester = new RuleTester()
1513

1614
ruleTester.run('group-exports', rule, {

0 commit comments

Comments
 (0)