refactor: replace usages of context.getScope

Author: G-Rath

src/rules/newline-after-import.js

@@ -7,7 +7,7 @@ import isStaticRequire from '../core/staticRequire';
 import docsUrl from '../docsUrl';
 
 import debug from 'debug';
-import { getFilename } from '../context';
+import { getFilename, getScope } from '../context';
 const log = debug('eslint-plugin-import:rules:newline-after-import');
 
 //------------------------------------------------------------------------------
@@ -195,10 +195,12 @@ module.exports = {
       },
       'Program:exit'() {
         log('exit processing for', context.getPhysicalFilename ? context.getPhysicalFilename() : getFilename(context));
-        const scopeBody = getScopeBody(context.getScope());
-        log('got scope:', scopeBody);
 
         requireCalls.forEach((node, index) => {
+          // todo: this probably isn't correct...
+          const scopeBody = getScopeBody(getScope(context, node));
+          log('got scope:', scopeBody);
+
           const nodePosition = findNodeIndexInScopeBody(scopeBody, node);
           log('node position in scope:', nodePosition);
 

src/rules/no-amd.js

@@ -4,6 +4,7 @@
  */
 
 import docsUrl from '../docsUrl';
+import { getScope } from '../context';
 
 //------------------------------------------------------------------------------
 // Rule Definition
@@ -23,7 +24,7 @@ module.exports = {
   create(context) {
     return {
       CallExpression(node) {
-        if (context.getScope().type !== 'module') { return; }
+        if (getScope(context, node).type !== 'module') { return; }
 
         if (node.callee.type !== 'Identifier') { return; }
         if (node.callee.name !== 'require' && node.callee.name !== 'define') { return; }

src/rules/no-commonjs.js

@@ -4,6 +4,7 @@
  */
 
 import docsUrl from '../docsUrl';
+import { getScope } from '../context';
 
 const EXPORT_MESSAGE = 'Expected "export" or "export default"';
 const IMPORT_MESSAGE = 'Expected "import" instead of "require()"';
@@ -107,7 +108,7 @@ module.exports = {
 
         // exports.
         if (node.object.name === 'exports') {
-          const isInScope = context.getScope()
+          const isInScope = getScope(context, node)
             .variables
             .some((variable) => variable.name === 'exports');
           if (!isInScope) {
@@ -117,7 +118,7 @@ module.exports = {
 
       },
       CallExpression(call) {
-        if (!validateScope(context.getScope())) { return; }
+        if (!validateScope(getScope(context, call))) { return; }
 
         if (call.callee.type !== 'Identifier') { return; }
         if (call.callee.name !== 'require') { return; }

src/rules/no-mutable-exports.js

@@ -1,4 +1,5 @@
 import docsUrl from '../docsUrl';
+import { getScope } from '../context';
 
 module.exports = {
   meta: {
@@ -32,15 +33,15 @@ module.exports = {
     }
 
     function handleExportDefault(node) {
-      const scope = context.getScope();
+      const scope = getScope(context, node);
 
       if (node.declaration.name) {
         checkDeclarationsInScope(scope, node.declaration.name);
       }
     }
 
     function handleExportNamed(node) {
-      const scope = context.getScope();
+      const scope = getScope(context, node);
 
       if (node.declaration)  {
         checkDeclaration(node.declaration);

src/rules/no-namespace.js

@@ -5,7 +5,7 @@
 
 import minimatch from 'minimatch';
 import docsUrl from '../docsUrl';
-import { getSourceCode } from '../context';
+import { getScope, getSourceCode } from '../context';
 
 /**
  * @param {MemberExpression} memberExpression
@@ -109,7 +109,7 @@ module.exports = {
           return;
         }
 
-        const scopeVariables = context.getScope().variables;
+        const scopeVariables = getScope(context, node).variables;
         const namespaceVariable = scopeVariables.find((variable) => variable.defs[0].node === node);
         const namespaceReferences = namespaceVariable.references;
         const namespaceIdentifiers = namespaceReferences.map((reference) => reference.identifier);

utils/declaredScope.js

@@ -4,6 +4,7 @@ exports.__esModule = true;
 
 /** @type {import('./declaredScope').default} */
 exports.default = function declaredScope(context, name) {
+  // todo: what should be done about this...
   const references = context.getScope().references;
   const reference = references.find((x) => x.identifier.name === name);
   if (!reference || !reference.resolved) { return undefined; }