Skip to content

Commit 568ca43

Browse files
saschanazljharb
authored andcommitted
[Fix] extensions: Fix ignorePackages to produce errors
1 parent fb8ae71 commit 568ca43

File tree

3 files changed

+32
-2
lines changed

3 files changed

+32
-2
lines changed

CHANGELOG.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,12 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
1212
- [`no-extraneous-dependencies`]: Implement support for [bundledDependencies](https://npm.github.io/using-pkgs-docs/package-json/types/bundleddependencies.html) ([#1436], thanks [@schmidsi]))
1313

1414
### Fixed
15-
- `default`: make error message less confusing ([#1470], thanks [@golopot])
15+
- [`default`]: make error message less confusing ([#1470], thanks [@golopot])
1616
- Improve performance of `ExportMap.for` by only loading paths when necessary. ([#1519], thanks [@brendo])
1717
- Support export of a merged TypeScript namespace declaration ([#1495], thanks [@benmunro])
1818
- [`import/order`]: fix autofix to not move imports across fn calls ([#1253], thanks [@tihonove])
1919
- [`prefer-default-export`]: fix false positive with type export ([#1506], thanks [@golopot])
20+
- [`extensions`]: Fix `ignorePackages` to produce errors ([#1521], thanks [@saschanaz])
2021

2122
## [2.18.2] - 2019-07-19
2223
- Skip warning on type interfaces ([#1425], thanks [@lencioni])
@@ -611,6 +612,7 @@ for info on changes for earlier releases.
611612

612613
[`memo-parser`]: ./memo-parser/README.md
613614

615+
[#1521]: https://github.com/benmosher/eslint-plugin-import/pull/1521
614616
[#1519]: https://github.com/benmosher/eslint-plugin-import/pull/1519
615617
[#1506]: https://github.com/benmosher/eslint-plugin-import/pull/1506
616618
[#1495]: https://github.com/benmosher/eslint-plugin-import/pull/1495
@@ -1001,3 +1003,4 @@ for info on changes for earlier releases.
10011003
[@benmunro]: https://github.com/benmunro
10021004
[@tihonove]: https://github.com/tihonove
10031005
[@brendo]: https://github.com/brendo
1006+
[@saschanaz]: https://github.com/saschanaz

src/rules/extensions.js

+5
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ function buildProperties(context) {
5050
}
5151
})
5252

53+
if (result.defaultConfig === 'ignorePackages') {
54+
result.defaultConfig = 'always'
55+
result.ignorePackages = true
56+
}
57+
5358
return result
5459
}
5560

tests/src/rules/extensions.js

+23-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ ruleTester.run('extensions', rule, {
6363
code: `
6464
import foo from './foo.js'
6565
import bar from './bar.json'
66-
import Component from './Component'
66+
import Component from './Component.jsx'
6767
import express from 'express'
6868
`,
6969
options: [ 'ignorePackages' ],
@@ -309,6 +309,28 @@ ruleTester.run('extensions', rule, {
309309
],
310310
}),
311311

312+
test({
313+
code: `
314+
import foo from './foo.js'
315+
import bar from './bar.json'
316+
import Component from './Component'
317+
import baz from 'foo/baz'
318+
import express from 'express'
319+
`,
320+
options: [ 'ignorePackages' ],
321+
errors: [
322+
{
323+
message: 'Missing file extension for "./Component"',
324+
line: 4,
325+
column: 31,
326+
}, {
327+
message: 'Missing file extension for "foo/baz"',
328+
line: 5,
329+
column: 25,
330+
},
331+
],
332+
}),
333+
312334
test({
313335
code: `
314336
import foo from './foo.js'

0 commit comments

Comments
 (0)