More tests, interop (ignore default missing if there are no imports at all), updated arg to 'es6-only'.

Author: benmosher

Diff for: lib/rules/default.js

@@ -19,7 +19,12 @@ module.exports = function (context) {
         return;
       }
 
-      if (!getExports(path).hasDefault) {
+      var imports = getExports(path);
+      if (imports.named.size === 0 && context.options[0] !== "es6-only") {
+        return; // ignore for commonjs compatibility
+      }
+
+      if (!imports.hasDefault) {
         context.report(defaultSpecifier, "No default export found in module.");
       }
     }

Diff for: lib/rules/named.js

@@ -18,7 +18,7 @@ module.exports = function (context) {
 
       // if there are no exports, may be a commonjs module.
       // TODO: "interop" mode that attempts to read module.exports, exports member assignments?
-      if (names.size === 0 && !imports.hasDefault && context.options[0] !== "es6") {
+      if (names.size === 0 && !imports.hasDefault && context.options[0] !== "es6-only") {
         return;
       }
 

Diff for: tests/lib/rules/default.js

@@ -21,30 +21,40 @@ eslintTester.addRuleTest("lib/rules/default", {
       code: "import foo from './default-export';",
       filename: FILENAME
     }, ecmaFeatures),
+
     assign({
       code: "import bar from './default-export';",
       filename: FILENAME
     }, ecmaFeatures),
+
     assign({
       code: "import CoolClass from './default-class';",
       filename: FILENAME
     }, ecmaFeatures),
+
     assign({
       code: "import bar, { baz } from './default-export';",
       filename: FILENAME
+    }, ecmaFeatures),
+
+    assign({
+      code: "import bar from './common';",
+      filename: FILENAME
     }, ecmaFeatures)
   ],
 
   invalid: [
-    // assign({
-    //   code: "import foo from './bar';",
-    //   filename: filename("foo.js"),
-    //   errors: ERRORS
-    // }, ecmaFeatures),
     assign({
       code: "import baz from './named-exports';",
       filename: FILENAME,
       errors: ERRORS
+    }, ecmaFeatures),
+
+    assign({
+      code: "import bar from './common';",
+      args: [2, "es6-only"],
+      filename: FILENAME,
+      errors: ERRORS
     }, ecmaFeatures)
   ]
 });

Diff for: tests/lib/rules/named.js

@@ -77,7 +77,7 @@ eslintTester.addRuleTest("lib/rules/named", {
 
     assign({
       code: "import { a } from './common';",
-      args: [2, "es6"],
+      args: [2, "es6-only"],
       filename: FILENAME,
       errors: ERRORS
     }, ecmaFeatures),