[Refactor] no-internal-modules: simplify a reduce

ljharb · ljharb · commit be928ae19461 · 2023-07-27T20:45:50.000-07:00
diff --git a/src/rules/no-internal-modules.js b/src/rules/no-internal-modules.js
@@ -58,16 +58,14 @@ module.exports = {
     }
 
     function toSteps(somePath) {
-      return  normalizeSep(somePath)
+      return normalizeSep(somePath)
         .split('/')
+        .filter((step) => step && step !== '.')
         .reduce((acc, step) => {
-          if (!step || step === '.') {
-            return acc;
-          } else if (step === '..') {
+          if (step === '..') {
             return acc.slice(0, -1);
-          } else {
-            return acc.concat(step);
           }
+          return acc.concat(step);
         }, []);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -58,16 +58,14 @@ module.exports = {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`function toSteps(somePath) {`
`61`		`- return normalizeSep(somePath)`
	`61`	`+ return normalizeSep(somePath)`
`62`	`62`	`.split('/')`
	`63`	`+ .filter((step) => step && step !== '.')`
`63`	`64`	`.reduce((acc, step) => {`
`64`		`- if (!step \|\| step === '.') {`
`65`		`- return acc;`
`66`		`- } else if (step === '..') {`
	`65`	`+ if (step === '..') {`
`67`	`66`	`return acc.slice(0, -1);`
`68`		`- } else {`
`69`		`- return acc.concat(step);`
`70`	`67`	`}`
	`68`	`+ return acc.concat(step);`
`71`	`69`	`}, []);`
`72`	`70`	`}`
`73`	`71`