Skip to content

Commit c612d14

Browse files
author
jeromeh
committed
[Defect 2066] add extraneous-dependencies unit tests
1 parent d7119ef commit c612d14

File tree

6 files changed

+19
-2
lines changed

6 files changed

+19
-2
lines changed

Diff for: tests/files/node_modules/rxjs/index.js

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: tests/files/node_modules/rxjs/operators/index.js

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: tests/files/node_modules/rxjs/operators/package.json

+5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: tests/files/node_modules/rxjs/package.json

+5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: tests/files/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
"@org/package": "^1.0.0",
1212
"jquery": "^3.1.0",
1313
"lodash.cond": "^4.3.0",
14-
"pkg-up": "^1.0.0"
14+
"pkg-up": "^1.0.0",
15+
"rxjs": "^1.0.0"
1516
},
1617
"optionalDependencies": {
1718
"lodash.isarray": "^4.0.0"

Diff for: tests/src/rules/no-extraneous-dependencies.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ ruleTester.run('no-extraneous-dependencies', rule, {
8888
}),
8989
test({
9090
code: `
91-
// @flow
91+
// @flow
9292
import typeof TypeScriptModule from 'typescript';
9393
`,
9494
options: [{ packageDir: packageDirWithFlowTyped }],
@@ -150,6 +150,10 @@ ruleTester.run('no-extraneous-dependencies', rule, {
150150
code: 'import "@generated/bar/and/sub/path"',
151151
settings: { 'import/core-modules': ['@generated/bar'] },
152152
}),
153+
// check if "rxjs" dependency declaration fix the "rxjs/operators subpackage
154+
test({
155+
code: 'import "rxjs/operators"',
156+
}),
153157
],
154158
invalid: [
155159
test({

0 commit comments

Comments
 (0)