Skip to content

Commit df15898

Browse files
committed
[Fix] ignore non-identifier imports
1 parent e464955 commit df15898

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/rules/order.js

+6
Original file line numberDiff line numberDiff line change
@@ -969,6 +969,12 @@ module.exports = {
969969
...named.require ? {
970970
VariableDeclarator: function orderRequireNames(node) {
971971
if (node.id.type === 'ObjectPattern' && isRequireExpression(node.init)) {
972+
for (let i = 0; i < node.id.properties.length; i++) {
973+
if (node.id.properties[i].key.type !== 'Identifier'
974+
|| node.id.properties[i].value.type !== 'Identifier') {
975+
return;
976+
}
977+
}
972978
makeNamedOrderReport(
973979
context,
974980
node.id.properties.map(

tests/src/rules/order.js

+2
Original file line numberDiff line numberDiff line change
@@ -1140,6 +1140,8 @@ ruleTester.run('order', rule, {
11401140
const { D, n: c, Y } = require('./Z');
11411141
export { C, D };
11421142
export { A, B, C as default } from "./Z";
1143+
1144+
const { ["ignore require-statements with non-identifier imports"]: z, d } = require("./Z");
11431145
`,
11441146
options: [{
11451147
named: true,

0 commit comments

Comments
 (0)