fix #328: properly suppress default when looking at * exports.

Author: benmosher

Diff for: src/core/getExports.js

@@ -228,7 +228,8 @@ export default class ExportMap {
     if (this.namespace.has(name)) return true
     if (this.reexports.has(name)) return true
 
-    for (let dep of this.dependencies.values()) {
+    // default exports must be explicitly re-exported (#328)
+    if (name !== 'default') for (let dep of this.dependencies.values()) {
       let innerMap = dep()
 
       // todo: report as unresolved?
@@ -264,7 +265,9 @@ export default class ExportMap {
       return deep
     }
 
-    for (let dep of this.dependencies.values()) {
+
+    // default exports must be explicitly re-exported (#328)
+    if (name !== 'default') for (let dep of this.dependencies.values()) {
       let innerMap = dep()
       // todo: report as unresolved?
       if (!innerMap) continue
@@ -298,7 +301,8 @@ export default class ExportMap {
       return imported.get(local)
     }
 
-    for (let dep of this.dependencies.values()) {
+    // default exports must be explicitly re-exported (#328)
+    if (name !== 'default') for (let dep of this.dependencies.values()) {
       let innerMap = dep()
       // todo: report as unresolved?
       if (!innerMap) continue
@@ -321,7 +325,7 @@ export default class ExportMap {
       callback.call(thisArg, getImport().get(local), name, this))
 
     this.dependencies.forEach(dep => dep().forEach((v, n) =>
-      callback.call(thisArg, v, n, this)))
+      n !== 'default' && callback.call(thisArg, v, n, this)))
   }
 
   // todo: keys, values, entries?

Diff for: src/rules/export.js

@@ -50,7 +50,7 @@ module.exports = function (context) {
         return
       }
       let any = false
-      remoteExports.forEach((v, name) => (any = true) && addNamed(name, node))
+      remoteExports.forEach((v, name) => name !== 'default' && (any = true) && addNamed(name, node))
 
       if (!any) {
         context.report(node.source,

Diff for: tests/files/deep-es7/b.js

@@ -1 +1,2 @@
 export * as c from './c'
+export default 'b'

Diff for: tests/files/deep/b.js

@@ -1,2 +1,3 @@
 import * as c from './c'
-export { c }
+export { c }
+export default 'b'

Diff for: tests/files/re-export.js

@@ -1,3 +1,6 @@
 export const c = 'foo'
 
 export * from './named-exports'
+
+// #328: this exports only 'foo', not the default.
+export * from './bar'

Diff for: tests/src/rules/default.js

@@ -115,5 +115,11 @@ ruleTester.run('default', rule, {
       parser: 'babel-eslint',
       errors: ['No default export found in module.'],
     }),
+
+    // #328: * exports do not include default
+    test({
+      code: 'import barDefault from "./re-export"',
+      errors: [`No default export found in module.`],
+    }),
   ],
 })

Diff for: tests/src/rules/export.js

@@ -21,6 +21,9 @@ ruleTester.run('export', rule, {
     test({ code: 'export { bar }; export * from "./export-all"' }),
     test({ code: 'export * from "./export-all"' }),
     test({ code: 'export * from "./does-not-exist"' }),
+
+    // #328: "export * from" does not export a default
+    test({ code: 'export default foo; export * from "./bar"' }),
   ],
 
   invalid: [
@@ -29,10 +32,6 @@ ruleTester.run('export', rule, {
       code: 'export default foo; export default bar',
       errors: ['Multiple default exports.', 'Multiple default exports.'],
     }),
-    test({
-      code: 'export default foo; export * from "./default-export"',
-      errors: ['Multiple default exports.', 'Multiple default exports.'],
-    }),
     test({
       code: 'export default function foo() {}; ' +
                  'export default function bar() {}',
@@ -99,5 +98,11 @@ ruleTester.run('export', rule, {
                'Multiple exports of name \'bar\'.'],
     }),
 
+
+    // #328: "export * from" does not export a default
+    test({
+      code: 'export * from "./default-export"',
+      errors: [`No named exports found in module './default-export'.`],
+    }),
   ],
 })

Diff for: tests/src/rules/named.js

@@ -217,5 +217,11 @@ ruleTester.run('named', rule, {
       // todo: better error message
       errors: ["common not found via re-export-default.js -> common.js"],
     }),
+
+    // #328: * exports do not include default
+    test({
+      code: 'import { default as barDefault } from "./re-export"',
+      errors: [`default not found in './re-export'`],
+    }),
   ],
 })

Diff for: tests/src/rules/namespace.js

@@ -77,6 +77,7 @@ const valid = [
 
   // names.default is valid export
   test({ code: "import * as names from './default-export';" }),
+  test({ code: "import * as names from './default-export'; console.log(names.default)" }),
   test({
    code: 'export * as names from "./default-export"',
    parser: 'babel-eslint',
@@ -164,6 +165,12 @@ const invalid = [
     errors: [error('c', 'names')],
   }),
 
+  // #328: * exports do not include default
+  test({
+    code: 'import * as ree from "./re-export"; console.log(ree.default)',
+    errors: [`'default' not found in imported namespace 'ree'.`],
+  }),
+
 ]
 
 ///////////////////////
@@ -177,6 +184,9 @@ const invalid = [
     test({ parser, code: `import * as a from "./${folder}/a"; var {b:{c:{d:{e}}}} = a` }),
     test({ parser, code: `import { b } from "./${folder}/a"; var {c:{d:{e}}} = b` }))
 
+    // deep namespaces should include explicitly exported defaults
+    test({ parser, code: `import * as a from "./${folder}/a"; console.log(a.b.default)` }),
+
   invalid.push(
     test({
       parser,