Skip to content

[no-extraneous-dependencies] false positive with electron #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcmxcdev opened this issue Aug 5, 2021 · 3 comments
Closed

[no-extraneous-dependencies] false positive with electron #2175

mcmxcdev opened this issue Aug 5, 2021 · 3 comments
Labels

Comments

@mcmxcdev
Copy link

mcmxcdev commented Aug 5, 2021

The linting rule complains that electron should be listed as dependency, not devDependency.

Electron clearly states on https://github.com/electron/electron#installation that it should be installed as a dev dependency.

@ljharb
Copy link
Member

ljharb commented Aug 5, 2021

By default, the rule always requires things to be a dependency, because that's the safest choice.

You can configure the rule to indicate in which file dev dependencies are permitted; see the docs.

@ljharb ljharb added the question label Aug 5, 2021
@mcmxcdev
Copy link
Author

mcmxcdev commented Aug 5, 2021

That doesn't seem feasible to me, because every file can potentially have a devDependency in it.

@ljharb
Copy link
Member

ljharb commented Aug 14, 2021

In that case, I think the only possible way to address it while keeping the rule enabled would be if we added an option that listed specific package names, and in which categories they're permitted.

… which makes this a duplicate of #903.

@ljharb ljharb closed this as completed Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants