Skip to content

Commit d78559a

Browse files
committed
bootstrap: tweak verbosity settings
Currently the verbosity settings are: - 2: RUSTC-SHIM envvars get spammed on every invocation, O(30) lines cargo is passed -v which outputs CLI invocations, O(5) lines - 3: cargo is passed -vv which outputs build script output, O(0-10) lines This commit changes it to: - 1: cargo is passed -v, O(5) lines - 2: cargo is passed -vv, O(10) lines - 3: RUSTC-SHIM envvars get spammed, O(30) lines
1 parent 7fbd4ce commit d78559a

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/bootstrap/bin/rustc.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ fn main() {
146146
}
147147

148148
let is_test = args.iter().any(|a| a == "--test");
149-
if verbose > 1 {
149+
if verbose > 2 {
150150
let rust_env_vars =
151151
env::vars().filter(|(k, _)| k.starts_with("RUST") || k.starts_with("CARGO"));
152152
let prefix = if is_test { "[RUSTC-SHIM] rustc --test" } else { "[RUSTC-SHIM] rustc" };

src/bootstrap/bootstrap.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -959,7 +959,7 @@ def build_bootstrap(self):
959959
self.cargo()))
960960
args = [self.cargo(), "build", "--manifest-path",
961961
os.path.join(self.rust_root, "src/bootstrap/Cargo.toml")]
962-
for _ in range(1, self.verbose):
962+
for _ in range(0, self.verbose):
963963
args.append("--verbose")
964964
if self.use_locked_deps:
965965
args.append("--locked")

src/bootstrap/builder.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1483,7 +1483,7 @@ impl<'a> Builder<'a> {
14831483
cargo.env("WINAPI_NO_BUNDLED_LIBRARIES", "1");
14841484
}
14851485

1486-
for _ in 1..self.verbosity {
1486+
for _ in 0..self.verbosity {
14871487
cargo.arg("-v");
14881488
}
14891489

0 commit comments

Comments
 (0)