fix(cardano-services-client): map blockfrost asset metadata files src from array to string

also log nft metadata mapping errors

Author: mkazlauskas

packages/cardano-services-client/src/AssetInfoProvider/BlockfrostAssetProvider.ts

@@ -27,7 +27,7 @@ export class BlockfrostAssetProvider extends BlockfrostProvider implements Asset
               .onchain_metadata!.files.map((file): Asset.NftMetadataFile | null => {
                 const mediaType = file.mediaType as string | undefined;
                 const fileName = file.name as string | undefined;
-                const src = file.src as string | undefined;
+                const src = this.metadatumToString(file.src as string | string[] | undefined);
                 if (!src || !mediaType) return null;
                 try {
                   return {
@@ -36,7 +36,8 @@ export class BlockfrostAssetProvider extends BlockfrostProvider implements Asset
                     otherProperties: this.mapNftMetadataOtherProperties(file),
                     src: Asset.Uri(src)
                   };
-                } catch {
+                } catch (error) {
+                  this.logger.warn('Failed to parse onchain_metadata file', file, error);
                   return null;
                 }
               })
@@ -50,7 +51,8 @@ export class BlockfrostAssetProvider extends BlockfrostProvider implements Asset
         otherProperties: this.mapNftMetadataOtherProperties(asset.onchain_metadata),
         version: '1.0'
       };
-    } catch {
+    } catch (error) {
+      this.logger.warn('Failed to parse nft metadata', asset, error);
       return null;
     }
   }
@@ -130,6 +132,7 @@ export class BlockfrostAssetProvider extends BlockfrostProvider implements Asset
         tokenMetadata: extraData?.tokenMetadata ? this.mapTokenMetadata(assetId, response) : null
       };
     } catch (error) {
+      this.logger.error('getAsset failed', assetId, extraData);
       throw this.toProviderError(error);
     }
   }

packages/cardano-services-client/src/blockfrost/BlockfrostProvider.ts

@@ -26,12 +26,12 @@ const toProviderFailure = (status: number | undefined): ProviderFailure => {
 };
 
 export abstract class BlockfrostProvider implements Provider {
-  #logger: Logger;
+  protected logger: Logger;
   #client: BlockfrostClient;
 
   constructor(client: BlockfrostClient, logger: Logger) {
     this.#client = client;
-    this.#logger = contextLogger(logger, this.constructor.name);
+    this.logger = contextLogger(logger, this.constructor.name);
   }
 
   /**
@@ -40,12 +40,12 @@ export abstract class BlockfrostProvider implements Provider {
    */
   protected async request<T>(endpoint: string): Promise<T> {
     try {
-      this.#logger.debug('request', endpoint);
+      this.logger.debug('request', endpoint);
       const response = await this.#client.request<T>(endpoint);
-      this.#logger.debug('response', response);
+      this.logger.debug('response', response);
       return response;
     } catch (error) {
-      this.#logger.error('error', error);
+      this.logger.error('error', error);
       throw this.toProviderError(error);
     }
   }

packages/cardano-services-client/test/AssetInfoProvider/BlockfrostAssetProvider.test.ts

@@ -169,5 +169,27 @@ describe('BlockfrostAssetProvider', () => {
         tokenMetadata: null
       });
     });
+
+    test('file src as array', async () => {
+      mockResponses(request, [
+        [
+          `assets/${mockedAssetId}`,
+          {
+            ...mockedAssetResponse,
+            onchain_metadata: {
+              ...mockedAssetResponse.onchain_metadata,
+              files: [{ mediaType: 'image/png', src: ['http://', 'some.png'] }]
+            }
+          }
+        ]
+      ]);
+
+      const response = await provider.getAsset({
+        assetId: mockedAssetId,
+        extraData: { nftMetadata: true }
+      });
+
+      expect(response.nftMetadata!.files![0].src).toBe('http://some.png');
+    });
   });
 });