fixup! fix(trezor): fix output format mapping on trezor HW devices

Author: AngelCastilloB

packages/hardware-trezor/src/TrezorKeyAgent.ts

@@ -237,37 +237,6 @@ export class TrezorKeyAgent extends KeyAgentBase {
     return Trezor.PROTO.CardanoTxSigningMode.ORDINARY_TRANSACTION;
   }
 
-  /**
-   * There are currently two types of outputs supported by the ledger:
-   *
-   * legacy_transaction_output =
-   *   [ address
-   *   , amount : value
-   *   , ? datum_hash : $hash32
-   *   ]
-   *
-   * and
-   *
-   * post_alonzo_transaction_output =
-   *   { 0 : address
-   *   , 1 : value
-   *   , ? 2 : datum_option ; New; datum option
-   *   , ? 3 : script_ref   ; New; script reference
-   *   }
-   *
-   * Legacy outputs are definite length arrays of three elements, however the new babbage outputs are definite length maps
-   * of four elements.
-   *
-   * @param outputs The outputs to be verified.
-   */
-  hasBabbageOutput(outputs: Array<Serialization.TransactionOutput>): boolean {
-    if (outputs.length === 0) return false;
-
-    const reader = new Serialization.CborReader(outputs[0].toCbor());
-
-    return reader.peekState() === Serialization.CborReaderState.StartMap;
-  }
-
   async signTransaction(
     txBody: Serialization.TransactionBody,
     { knownAddresses, txInKeyPathMap, scripts }: SignTransactionContext
@@ -283,7 +252,7 @@ export class TrezorKeyAgent extends KeyAgentBase {
         knownAddresses,
         tagCborSets: txBody.hasTaggedSets(),
         txInKeyPathMap,
-        useBabbageOutputs: this.hasBabbageOutput(txBody.outputs())
+        useBabbageOutputs: txBody.hasBabbageOutput()
       });
 
       const signingMode = TrezorKeyAgent.matchSigningMode(trezorTxData);

packages/hardware-trezor/test/transformers/tx.test.ts

@@ -204,7 +204,8 @@ describe('tx', () => {
           ...contextWithKnownAddresses,
           txInKeyPathMap: {
             [TxInId(babbageTxBodyWithScripts.inputs[0])]: knownAddressPaymentKeyPath
-          }
+          },
+          useBabbageOutputs: true
         })
       ).toEqual({
         additionalWitnessRequests: [
@@ -327,7 +328,8 @@ describe('tx', () => {
           txInKeyPathMap: {
             [TxInId(plutusTxWithBabbage.inputs[0])]: knownAddressPaymentKeyPath,
             [TxInId(plutusTxWithBabbage.collaterals[0])]: knownAddressPaymentKeyPath
-          }
+          },
+          useBabbageOutputs: true
         })
       ).toEqual({
         additionalWitnessRequests: [
@@ -361,7 +363,7 @@ describe('tx', () => {
           address:
             'addr_test1qz2fxv2umyhttkxyxp8x0dlpdt3k6cwng5pxj3jhsydzer3jcu5d8ps7zex2k2xt3uqxgjqnnj83ws8lhrn648jjxtwq2ytjqp',
           amount: '10',
-          format: Trezor.PROTO.CardanoTxOutputSerializationFormat.ARRAY_LEGACY
+          format: Trezor.PROTO.CardanoTxOutputSerializationFormat.MAP_BABBAGE
         },
         fee: '10',
         inputs: [