refactor(tx-construction): txOutputBuilder satisfies OutputBuilder interface

Using GenericTxBuilder.buildOutput should give access to all properties
of TxOutputBuilder, instead of just OutputBuilder interface.

Author: mirceahasegan

packages/e2e/test/wallet/PersonalWallet/multiAddress.test.ts

@@ -65,17 +65,13 @@ describe('PersonalWallet/multiAddress', () => {
       );
 
       addressesToBeDiscovered.push(address);
-
-      const txOutput = await txBuilder.buildOutput().address(address.address).coin(3_000_000n).build();
-      txBuilder.addOutput(txOutput);
+      txBuilder.addOutput(txBuilder.buildOutput().address(address.address).coin(3_000_000n).toTxOut());
     }
 
     // Remove duplicates
     addressesToBeDiscovered = [...new Set(addressesToBeDiscovered)];
 
-    const unsignedTx = txBuilder.build();
-
-    const { tx: signedTx } = await unsignedTx.sign();
+    const { tx: signedTx } = await txBuilder.build().sign();
 
     await wallet.submitTx(signedTx);
 
@@ -125,17 +121,17 @@ describe('PersonalWallet/multiAddress', () => {
     txBuilder = newWallet.wallet.createTxBuilder();
 
     const fundingWalletAddresses = await firstValueFromTimed(wallet.addresses$);
-    const returnAdaOutput = await txBuilder
-      .buildOutput()
-      .address(fundingWalletAddresses[0].address)
-      .coin(totalBalance.coins - 1_500_000n) // Let's leave some behind for fees.
-      .build();
-
-    txBuilder.addOutput(returnAdaOutput);
 
-    const returnAdaUnsignedTx = await txBuilder.build();
-
-    const { tx: returnAdaSignedTx } = await returnAdaUnsignedTx.sign();
+    const { tx: returnAdaSignedTx } = await txBuilder
+      .addOutput(
+        txBuilder
+          .buildOutput()
+          .address(fundingWalletAddresses[0].address)
+          .coin(totalBalance.coins - 1_500_000n) // Let's leave some behind for fees.
+          .toTxOut()
+      )
+      .build()
+      .sign();
     await newWallet.wallet.submitTx(returnAdaSignedTx);
 
     // Search chain history to see if the transaction is there.

packages/tx-construction/src/tx-builder/OutputBuilder.ts

@@ -93,42 +93,42 @@ export class TxOutputBuilder implements OutputBuilder {
     return this.#partialOutput;
   }
 
-  value(value: Cardano.Value): OutputBuilder {
+  value(value: Cardano.Value): TxOutputBuilder {
     this.#partialOutput = { ...this.#partialOutput, value: { ...value } };
     return this;
   }
 
-  coin(coin: Cardano.Lovelace): OutputBuilder {
+  coin(coin: Cardano.Lovelace): TxOutputBuilder {
     this.#partialOutput = { ...this.#partialOutput, value: { ...this.#partialOutput?.value, coins: coin } };
     return this;
   }
 
-  assets(assets: Cardano.TokenMap): OutputBuilder {
+  assets(assets: Cardano.TokenMap): TxOutputBuilder {
     this.#partialOutput = {
       ...this.#partialOutput,
       value: { ...this.#partialOutput?.value, assets }
     };
     return this;
   }
 
-  asset(assetId: Cardano.AssetId, quantity: bigint): OutputBuilder {
+  asset(assetId: Cardano.AssetId, quantity: bigint): TxOutputBuilder {
     const assets: Cardano.TokenMap = new Map(this.#partialOutput?.value?.assets);
     quantity === 0n ? assets.delete(assetId) : assets.set(assetId, quantity);
 
     return this.assets(assets);
   }
 
-  address(address: Cardano.PaymentAddress): OutputBuilder {
+  address(address: Cardano.PaymentAddress): TxOutputBuilder {
     this.#partialOutput = { ...this.#partialOutput, address };
     return this;
   }
 
-  datum(datumHash: Hash32ByteBase16): OutputBuilder {
+  datum(datumHash: Hash32ByteBase16): TxOutputBuilder {
     this.#partialOutput = { ...this.#partialOutput, datumHash };
     return this;
   }
 
-  handle(handle: Handle): OutputBuilder {
+  handle(handle: Handle): TxOutputBuilder {
     if (!this.#handleProvider) {
       throw new InvalidConfigurationError(TxOutputFailure.MissingHandleProviderError);
     }

packages/tx-construction/src/tx-builder/TxBuilder.ts

@@ -2,7 +2,6 @@ import * as Crypto from '@cardano-sdk/crypto';
 import { Cardano, HandleProvider, HandleResolution } from '@cardano-sdk/core';
 import { Logger } from 'ts-log';
 import {
-  OutputBuilder,
   OutputBuilderTxOut,
   PartialTx,
   PartialTxOut,
@@ -134,7 +133,7 @@ export class GenericTxBuilder implements TxBuilder {
     return this;
   }
 
-  buildOutput(txOut?: PartialTxOut): OutputBuilder {
+  buildOutput(txOut?: PartialTxOut): TxOutputBuilder {
     return new TxOutputBuilder({
       handleProvider: this.#handleProvider,
       logger: contextLogger(this.#logger, 'outputBuilder'),