fix: add sideEffects=false to package.json

mkazlauskas · mkazlauskas · commit a1cb8f807e8d · 2022-12-05T14:57:38.000+02:00
needed for webpack tree shaking to work
diff --git a/packages/cardano-services-client/package.json b/packages/cardano-services-client/package.json
@@ -13,6 +13,7 @@
       "require": "./dist/cjs/index.js"
     }
   },
+  "sideEffects": false,
   "repository": "https://github.com/input-output-hk/cardano-js-sdk",
   "publishConfig": {
     "access": "public"
diff --git a/packages/cardano-services/package.json b/packages/cardano-services/package.json
@@ -18,6 +18,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/dapp-connector/package.json b/packages/dapp-connector/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/e2e/package.json b/packages/e2e/package.json
@@ -13,6 +13,9 @@
       "require": "./dist/cjs/index.js"
     }
   },
+  "sideEffects": [
+    "./test/web-extension/extension/**/*.ts"
+  ],
   "scripts": {
     "artillery:stake-pool-query": "WORKERS=1 node -r ts-node/register ../../node_modules/.bin/artillery run test/artillery/StakePoolSearch.yml",
     "artillery:wallet-restoration": "WORKERS=1 node -r ts-node/register ../../node_modules/.bin/artillery run --dotenv ./.env test/artillery/wallet-restoration/WalletRestoration.yml",
diff --git a/packages/golden-test-generator/package.json b/packages/golden-test-generator/package.json
@@ -18,6 +18,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/governance/package.json b/packages/governance/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/input-selection/package.json b/packages/input-selection/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/key-management/package.json b/packages/key-management/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/ogmios/package.json b/packages/ogmios/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/projection/package.json b/packages/projection/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/util-dev/package.json b/packages/util-dev/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/util-rxjs/package.json b/packages/util-rxjs/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/util/package.json b/packages/util/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/wallet/package.json b/packages/wallet/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",
diff --git a/packages/web-extension/package.json b/packages/web-extension/package.json
@@ -17,6 +17,7 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
   "contributors": [
     "Rhys Bartels-Waller <rhys.bartelswaller@iohk.io> (https://iohk.io)",
     "Martynas Kazlauskas <martynas.kazlauskas@iohk.io> (https://iohk.io)",

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`"require": "./dist/cjs/index.js"`
`14`	`14`	`}`
`15`	`15`	`},`
	`16`	`+ "sideEffects": false,`
`16`	`17`	`"repository": "https://github.com/input-output-hk/cardano-js-sdk",`
`17`	`18`	`"publishConfig": {`
`18`	`19`	`"access": "public"`