refactor!: lift deepEquals to util package in preparation for further wallet decomposition

There are most likely more generic equals utils remaining, but I'm just being minimal for now

Author: rhyslbw

packages/util/src/equals.ts

@@ -0,0 +1,3 @@
+import isEqual from 'lodash/isEqual';
+
+export const deepEquals = <T>(a: T, b: T) => isEqual(a, b);

packages/util/src/index.ts

@@ -1,3 +1,4 @@
+export * from './equals';
 export * from './types';
 export * from './BigIntMath';
 export * from './hexString';

packages/util/test/equals.test.ts

@@ -0,0 +1,10 @@
+import { deepEquals } from '../src';
+
+describe('equals', () => {
+  test('deepEquals', () => {
+    expect(deepEquals([], [])).toBe(true);
+    expect(deepEquals({}, {})).toBe(true);
+    expect(deepEquals([{ prop: 'prop' }], [{ prop: 'prop' }])).toBe(true);
+    expect(deepEquals([{ prop: 'prop' }], [{ prop: 'prop2' }])).toBe(false);
+  });
+});

packages/wallet/src/KeyManagement/util/stubSignTransaction.ts

@@ -1,6 +1,6 @@
 import { Address, Cardano } from '@cardano-sdk/core';
 import { GroupedAddress, SignTransactionOptions, TransactionSigner } from '../types';
-import { deepEquals } from '../../services';
+import { deepEquals } from '@cardano-sdk/util';
 import { ownSignatureKeyPaths } from './ownSignatureKeyPaths';
 import uniqWith from 'lodash/uniqWith';
 

packages/wallet/src/SingleAddressWallet.ts

@@ -58,7 +58,6 @@ import {
   createUtxoTracker,
   createWalletUtil,
   currentEpochTracker,
-  deepEquals,
   distinctBlock,
   distinctEraSummaries,
   groupedAddressesEquals
@@ -86,7 +85,7 @@ import { Cip30DataSignature } from '@cardano-sdk/cip30';
 import { InputSelector, defaultSelectionConstraints, roundRobinRandomImprove } from '@cardano-sdk/cip2';
 import { Logger } from 'ts-log';
 import { RetryBackoffConfig } from 'backoff-rxjs';
-import { Shutdown, bufferToHexString, contextLogger } from '@cardano-sdk/util';
+import { Shutdown, bufferToHexString, contextLogger, deepEquals } from '@cardano-sdk/util';
 import { TrackedUtxoProvider } from './services/ProviderTracker/TrackedUtxoProvider';
 import { WalletStores, createInMemoryWalletStores } from './persistence';
 import { cip30signData } from './KeyManagement/cip8';

packages/wallet/src/TxBuilder/buildTx.ts

@@ -15,15 +15,9 @@ import {
   TxOutValidationError
 } from './types';
 import { ObservableWalletTxOutputBuilder, toOutputValidationError } from './OutputBuilder';
-import {
-  OutputValidator,
-  RewardAccount,
-  StakeKeyStatus,
-  WalletUtilContext,
-  createWalletUtil,
-  deepEquals
-} from '../services';
+import { OutputValidator, RewardAccount, StakeKeyStatus, WalletUtilContext, createWalletUtil } from '../services';
 import { SignTransactionOptions, TransactionSigner } from '../KeyManagement';
+import { deepEquals } from '@cardano-sdk/util';
 
 /**
  * Minimal sub-type of ObservableWallet that is used by TxBuilder.

packages/wallet/src/services/DelegationTracker/RewardAccounts.ts

@@ -1,5 +1,5 @@
 /* eslint-disable unicorn/no-nested-ternary */
-import { BigIntMath, isNotNil } from '@cardano-sdk/util';
+import { BigIntMath, deepEquals, isNotNil } from '@cardano-sdk/util';
 import { Cardano, RewardsProvider } from '@cardano-sdk/core';
 import { Delegatee, RewardAccount, StakeKeyStatus } from '../types';
 import { KeyValueStore } from '../../persistence';
@@ -12,7 +12,7 @@ import {
 import { RetryBackoffConfig } from 'backoff-rxjs';
 import { TrackedStakePoolProvider } from '../ProviderTracker';
 import { TxWithEpoch } from './types';
-import { coldObservableProvider, deepEquals, shallowArrayEquals } from '../util';
+import { coldObservableProvider, shallowArrayEquals } from '../util';
 import findLast from 'lodash/findLast';
 import isEqual from 'lodash/isEqual';
 import uniq from 'lodash/uniq';

packages/wallet/src/services/util/equals.ts

@@ -1,11 +1,8 @@
 import { Cardano, EpochInfo, EraSummary } from '@cardano-sdk/core';
 import { GroupedAddress } from '../../KeyManagement';
-import isEqual from 'lodash/isEqual';
 
 export const strictEquals = <T>(a: T, b: T) => a === b;
 
-export const deepEquals = <T>(a: T, b: T) => isEqual(a, b);
-
 export const arrayEquals = <T>(arrayA: T[], arrayB: T[], itemEquals: (a: T, b: T) => boolean) =>
   arrayA.length === arrayB.length && arrayA.every((a) => arrayB.some((b) => itemEquals(a, b)));
 

packages/wallet/test/services/util/equals.test.ts

@@ -3,7 +3,6 @@ import { Cardano, EpochInfo, EraSummary } from '@cardano-sdk/core';
 import { GroupedAddress } from '../../../src/KeyManagement';
 import {
   arrayEquals,
-  deepEquals,
   epochInfoEquals,
   eraSummariesEquals,
   groupedAddressesEquals,
@@ -38,13 +37,6 @@ describe('equals', () => {
     expect(shallowArrayEquals([a], [a])).toBe(true);
   });
 
-  test('deepEquals', () => {
-    expect(deepEquals([], [])).toBe(true);
-    expect(deepEquals({}, {})).toBe(true);
-    expect(deepEquals([{ prop: 'prop' }], [{ prop: 'prop' }])).toBe(true);
-    expect(deepEquals([{ prop: 'prop' }], [{ prop: 'prop2' }])).toBe(false);
-  });
-
   test('txEquals', () => {
     expect(txEquals({ id: txId1 } as Cardano.TxAlonzo, { id: txId2 } as Cardano.TxAlonzo)).toBe(false);
     expect(txEquals({ id: txId1 } as Cardano.TxAlonzo, { id: txId1 } as Cardano.TxAlonzo)).toBe(true);