Skip to content

Commit d706a3d

Browse files
authored
Merge pull request #667 from input-output-hk/test/fix-not-deterministic-error
test(cardano-services): fixes a not deterministic error in tests
2 parents 60cd75b + 7c780c6 commit d706a3d

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

Diff for: packages/cardano-services/test/StakePool/HttpStakePoolMetadataService/HttpMetadataService.test.ts

+8-11
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { Cardano } from '@cardano-sdk/core';
55
import { DataMocks } from '../../data-mocks';
66
import { ExtMetadataFormat } from '../../../src/StakePool/types';
77
import { Hash32ByteBase16 } from '@cardano-sdk/crypto';
8+
import { IncomingMessage } from 'http';
89
import {
910
StakePoolMetadataServiceError,
1011
StakePoolMetadataServiceFailure,
@@ -202,23 +203,19 @@ describe('StakePoolMetadataService', () => {
202203
it('returns StakePoolMetadataServiceError with FailedToFetchExtendedSignature error code when it cant fetch the signature', async () => {
203204
let metadata: any;
204205

205-
let alreadyCalled = false;
206-
const handler = async () => {
207-
if (alreadyCalled) return { body: cip6ExtMetadataMock, code: 200 };
208-
alreadyCalled = true;
206+
const handler = async (req?: IncomingMessage) => {
207+
if (req?.url === '/cip-6') return { body: cip6ExtMetadataMock, code: 200 };
208+
if (req?.url === '/metadata') return { body: metadata, code: 200 };
209209

210-
return {
211-
body: metadata,
212-
code: 200
213-
};
210+
return { body: 'not found', code: 404 };
214211
};
215212

216213
({ closeMock, serverUrl } = await mockPoolExtMetadataServer(handler));
217214

218215
metadata = {
219216
...mainExtMetadataMock,
220217
extDataUrl: `${serverUrl}/${ExtMetadataFormat.CIP6}`,
221-
extSigUrl: UNFETCHABLE,
218+
extSigUrl: `${serverUrl}/not/found`,
222219
extVkey: '00000000000000000000000000000000'
223220
};
224221

@@ -235,8 +232,8 @@ describe('StakePoolMetadataService', () => {
235232
errors: [
236233
new StakePoolMetadataServiceError(
237234
StakePoolMetadataServiceFailure.FailedToFetchExtendedSignature,
238-
new Error('getaddrinfo EAI_AGAIN some_url'),
239-
`StakePoolMetadataService failed to fetch extended signature from ${UNFETCHABLE} due to connection error`
235+
null,
236+
`StakePoolMetadataService failed to fetch extended signature from ${metadata.extSigUrl} due to connection error`
240237
)
241238
],
242239
metadata

0 commit comments

Comments
 (0)