refactor(cardano-services): optimize get gov_action_proposals query

The 'tag' attribute in the 'description' field is a duplication of the field 'type';
reduce one field from the query to use the attribute in the JSON.

Author: iccicci

packages/cardano-services/src/ChainHistory/DbSyncChainHistory/ChainHistoryBuilder.ts

@@ -93,14 +93,16 @@ const mapWithdrawals: (source: [{ credential: DbSyncCredential; network: string
 const getGovernanceAction = ({
   denominator,
   description,
-  numerator,
-  type
+  numerator
 }: ProposalProcedureModel): Cardano.GovernanceAction => {
-  const { contents } = description;
+  const { contents, tag } = description;
   const governanceActionId =
     contents && contents[0] ? { actionIndex: contents[0].govActionIx, id: contents[0].txId } : null;
 
-  switch (type) {
+  if (!tag) throw new Error('Missing "tag" in governance action proposal description');
+  if (typeof tag !== 'string') throw new Error('Wrong "tag" type in governance action proposal description');
+
+  switch (tag) {
     case 'HardForkInitiation':
       return {
         __typename: GovernanceActionType.hard_fork_initiation_action,
@@ -159,7 +161,7 @@ const getGovernanceAction = ({
       };
   }
 
-  throw new Error(`Unknown GovernanceActionType '${type}' with description "${JSON.stringify(description)}"`);
+  throw new Error(`Unknown GovernanceActionType '${tag}' with description "${JSON.stringify(description)}"`);
 };
 
 const getVoter = (

packages/cardano-services/src/ChainHistory/DbSyncChainHistory/queries.ts

@@ -222,7 +222,6 @@ export const findProposalProceduresByTxIds = `
 		tx.hash AS tx_id,
 		ga.deposit,
 		ga.description,
-		ga.type,
 		va.url,
 		va.data_hash,
 		sa.view,

packages/cardano-services/src/ChainHistory/DbSyncChainHistory/types.ts

@@ -137,7 +137,6 @@ export interface ProposalProcedureModel {
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   description: any;
   tx_id: Buffer;
-  type: string;
   url: string;
   view: string;
   // LW-9675