fixup! fix(core): withdrawal calculation in computeImplicitCoin

Author: przemyslaw-wlodek

packages/core/src/Cardano/util/computeImplicitCoin.ts

@@ -154,6 +154,13 @@ const getTxDeposits = (
   };
 };
 
+const getOwnWithdrawals = (withdrawals: Cardano.Withdrawal[], rewardAccounts: Address.RewardAccount[]) =>
+  BigIntMath.sum(
+    withdrawals
+      .filter(({ stakeAddress }) => stakeAddressInRewardAccounts(stakeAddress, rewardAccounts))
+      .map(({ quantity }) => quantity)
+  );
+
 /**
  * Computes the implicit coin from the given transaction.
  * If rewardAccounts is provided, it will only count the deposits from
@@ -174,7 +181,7 @@ export const computeImplicitCoin = (
   {
     certificates,
     proposalProcedures,
-    withdrawals
+    withdrawals = []
   }: Pick<Cardano.HydratedTxBody, 'certificates' | 'proposalProcedures' | 'withdrawals'>,
   rewardAccounts?: Address.RewardAccount[],
   dRepKeyHash?: Crypto.Ed25519KeyHashHex
@@ -187,11 +194,9 @@ export const computeImplicitCoin = (
     proposalProcedures
   );
 
-  const ownWithdrawals =
-    rewardAccounts && withdrawals
-      ? withdrawals.filter((withdrawal) => stakeAddressInRewardAccounts(withdrawal.stakeAddress, rewardAccounts))
-      : [];
-  const withdrawalsTotal = BigIntMath.sum(ownWithdrawals.map(({ quantity }) => quantity)) || 0n;
+  const hasRewardAccount = !!rewardAccounts?.length;
+  const withdrawalsAll = BigIntMath.sum(withdrawals.map(({ quantity }) => quantity));
+  const withdrawalsTotal = hasRewardAccount ? getOwnWithdrawals(withdrawals, rewardAccounts) : withdrawalsAll;
 
   return {
     deposit,