[CO-410] Add golden decoding tests for legacy ProtocolMagic encoding

Author: Jimbo4350

crypto/test/Test/Pos/Crypto/Example.hs

@@ -2,6 +2,8 @@ module Test.Pos.Crypto.Example
     ( exampleProtocolMagic0
     , exampleProtocolMagic1
     , exampleProtocolMagic2
+    , exampleProtocolMagic3
+    , exampleProtocolMagic4
     ) where
 
 import           Pos.Crypto (ProtocolMagic (..), ProtocolMagicId (..),
@@ -19,3 +21,10 @@ exampleProtocolMagic1 = ProtocolMagic (ProtocolMagicId 2147000001) RequiresMagic
 
 exampleProtocolMagic2 :: ProtocolMagic
 exampleProtocolMagic2 = ProtocolMagic (ProtocolMagicId (- 58952)) RequiresMagic
+
+exampleProtocolMagic3 :: ProtocolMagic
+exampleProtocolMagic3 = ProtocolMagic (ProtocolMagicId (31337)) RequiresMagic
+
+exampleProtocolMagic4 :: ProtocolMagic
+exampleProtocolMagic4 = ProtocolMagic (ProtocolMagicId (- 500)) RequiresNoMagic
+

crypto/test/Test/Pos/Crypto/Json.hs

@@ -6,7 +6,8 @@ import           Hedgehog (Property)
 import qualified Hedgehog as H
 
 import           Test.Pos.Crypto.Example (exampleProtocolMagic0,
-                     exampleProtocolMagic1, exampleProtocolMagic2)
+                     exampleProtocolMagic1, exampleProtocolMagic2,
+                     exampleProtocolMagic3, exampleProtocolMagic4)
 import           Test.Pos.Util.Golden (discoverGolden, goldenTestJSONDec)
 
 --------------------------------------------------------------------------------
@@ -35,5 +36,20 @@ golden_ProtocolMagic2AesonDec =
         exampleProtocolMagic2
             "test/golden/json/ProtocolMagic2_Legacy_HasNetworkMagic"
 
+-- Legacy JSON encoding where requiresNetworkMagic was
+-- encoded as "NMMustBeNothing" or "NMMustBeJust"
+
+golden_ProtocolMagic3AesonDec_NMMustBeJust :: Property
+golden_ProtocolMagic3AesonDec_NMMustBeJust =
+    goldenTestJSONDec
+        exampleProtocolMagic3
+            "test/golden/json/ProtocolMagic_Legacy_NMMustBeJust"
+
+golden_ProtocolMagic4AesonDec_NMMustBeNothing :: Property
+golden_ProtocolMagic4AesonDec_NMMustBeNothing =
+    goldenTestJSONDec
+        exampleProtocolMagic4
+            "test/golden/json/ProtocolMagic_Legacy_NMMustBeNothing"
+
 tests :: IO Bool
 tests = H.checkSequential $$discoverGolden

crypto/test/golden/json/ProtocolMagic0_Legacy_RequiresMagic renamed to crypto/test/golden/json/ProtocolMagic_Legacy_NMMustBeJust

@@ -0,0 +1 @@
+{"pm":-500,"requiresNetworkMagic":"NMMustBeNothing"}