[CDEC-500] Add Json+Bi golden tests for Address

Since we are modifying this for CO-354, and it's quite important to
preserve backwards compatibility of Addresses, I've added 5 golden
tests to ensure the various configurations of Addresses will have
proper test coverage. 4 example Address datatypes are added to the
1 existing datatype, and all 5 are used for golden tests in both
the `Json` and `Bi` modules.

Author: mhuesch

core/test/Test/Pos/Core/Bi.hs

@@ -44,7 +44,8 @@ import           Test.Pos.Binary.Helpers (SizeTestConfig (..), scfg, sizeTest)
 import           Test.Pos.Binary.Helpers.GoldenRoundTrip (goldenTestBi,
                      roundTripsBiBuildable, roundTripsBiShow)
 import           Test.Pos.Core.ExampleHelpers (exampleAddrSpendingData_PubKey,
-                     exampleAddress, exampleBlockVersion,
+                     exampleAddress, exampleAddress1, exampleAddress2,
+                     exampleAddress3, exampleAddress4, exampleBlockVersion,
                      exampleBlockVersionData, exampleBlockVersionModifier,
                      exampleCommitment, exampleCommitmentSignature,
                      exampleCommitmentsMap, exampleEpochIndex, exampleHashTx,
@@ -78,7 +79,19 @@ import           Test.Pos.Util.Tripping (discoverRoundTrip)
 -- Address
 --------------------------------------------------------------------------------
 golden_Address :: Property
-golden_Address = goldenTestBi exampleAddress "test/golden/Address"
+golden_Address = goldenTestBi exampleAddress "test/golden/bi/Address0"
+
+golden_Address1 :: Property
+golden_Address1 = goldenTestBi exampleAddress1 "test/golden/bi/Address1"
+
+golden_Address2 :: Property
+golden_Address2 = goldenTestBi exampleAddress2 "test/golden/bi/Address2"
+
+golden_Address3 :: Property
+golden_Address3 = goldenTestBi exampleAddress3 "test/golden/bi/Address3"
+
+golden_Address4 :: Property
+golden_Address4 = goldenTestBi exampleAddress4 "test/golden/bi/Address4"
 
 roundTripAddressBi :: Property
 roundTripAddressBi = eachOf 1000 genAddress roundTripsBiBuildable

core/test/Test/Pos/Core/ExampleHelpers.hs

@@ -3,6 +3,10 @@ module Test.Pos.Core.ExampleHelpers
 
           exampleAddrSpendingData_PubKey
         , exampleAddress
+        , exampleAddress1
+        , exampleAddress2
+        , exampleAddress3
+        , exampleAddress4
         , exampleBlockVersion
         , exampleBlockVersionData
         , exampleBlockVersionModifier
@@ -83,6 +87,7 @@ import           Data.Fixed (Fixed (..))
 import qualified Data.HashMap.Strict as HM
 import           Data.List (zipWith4, (!!))
 import           Data.List.NonEmpty (fromList)
+import qualified Data.Map as M
 import           Data.Maybe (fromJust)
 import qualified Data.Text as T
 import           Data.Time.Units (Millisecond)
@@ -99,8 +104,8 @@ import           Pos.Core.Common (AddrAttributes (..), AddrSpendingData (..),
                      CoinPortion (..), IsBootstrapEraAddr (..), Script (..),
                      ScriptVersion, SharedSeed (..), SlotLeaders,
                      StakeholderId, StakesList, TxFeePolicy (..),
-                     TxSizeLinear (..), addressHash, makeAddress,
-                     makePubKeyAddress)
+                     TxSizeLinear (..), addressHash, coinPortionDenominator,
+                     makeAddress, makePubKeyAddress, mkMultiKeyDistr)
 import           Pos.Core.Configuration
 import           Pos.Core.Delegation (HeavyDlgIndex (..), LightDlgIndices (..),
                      ProxySKBlockInfo, ProxySKHeavy)
@@ -564,6 +569,50 @@ exampleAddress = makeAddress exampleAddrSpendingData_PubKey attrs
     attrs = AddrAttributes hap BootstrapEraDistr
     hap = Just (HDAddressPayload (getBytes 32 32))
 
+exampleAddress1 :: Address
+exampleAddress1 = makeAddress easd attrs
+  where
+    easd = PubKeyASD pk
+    [pk] = examplePublicKeys 24 1
+    attrs = AddrAttributes hap BootstrapEraDistr
+    hap = Nothing
+
+exampleAddress2 :: Address
+exampleAddress2 = makeAddress easd attrs
+  where
+    easd = RedeemASD exampleRedeemPublicKey
+    attrs = AddrAttributes hap asd
+    hap = Just (HDAddressPayload (getBytes 15 32))
+    asd = SingleKeyDistr exampleStakeholderId
+
+exampleAddress3 :: Address
+exampleAddress3 = makeAddress easd attrs
+  where
+    easd = ScriptASD exampleScript
+    attrs = AddrAttributes hap exampleMultiKeyDistr
+    hap = Just (HDAddressPayload (getBytes 17 32))
+
+exampleAddress4 :: Address
+exampleAddress4 = makeAddress easd attrs
+  where
+    easd = UnknownASD 7 "test value"
+    attrs = AddrAttributes Nothing (SingleKeyDistr sId)
+    [sId] = exampleStakeholderIds 7 1
+
+exampleMultiKeyDistr :: AddrStakeDistribution
+exampleMultiKeyDistr = case mkMultiKeyDistr (M.fromList pairs) of
+    Left err -> error $
+        "exampleMultiKeyDistr: improperly constructed stake map: " <> show err
+    Right asd -> asd
+  where
+    pairs = zip stakeIds (map CoinPortion (remainderCP : coinPortions))
+    stakeIds = map abstractHash (examplePublicKeys 7 4)
+    coinPortions = [ (10 :: Word64) ^ (12 :: Word64)
+                   , ( 7 :: Word64) ^ (11 :: Word64)
+                   , ( 6 :: Word64) ^ (14 :: Word64)
+                   ]
+    remainderCP = coinPortionDenominator - sum coinPortions
+
 exampleGenesisConfiguration_GCSrc :: GenesisConfiguration
 exampleGenesisConfiguration_GCSrc =
     GCSrc "dRaMwdYsH3QA3dChe" (abstractHash (Raw "Test"))

core/test/Test/Pos/Core/Json.hs

@@ -5,11 +5,12 @@ import qualified Hedgehog as H
 
 import           Pos.Core.JsonLog.LogEvents (InvReqDataFlowLog (..))
 
-import           Test.Pos.Core.ExampleHelpers
-                     (exampleGenesisConfiguration_GCSpec,
+import           Test.Pos.Core.ExampleHelpers (exampleAddress, exampleAddress1,
+                     exampleAddress2, exampleAddress3, exampleAddress4,
+                     exampleGenesisConfiguration_GCSpec,
                      exampleGenesisConfiguration_GCSrc, feedPM)
-import           Test.Pos.Core.Gen (genBlockVersionData, genByte, genCoin,
-                     genCoinPortion, genEpochIndex, genFlatSlotId,
+import           Test.Pos.Core.Gen (genAddress, genBlockVersionData, genByte,
+                     genCoin, genCoinPortion, genEpochIndex, genFlatSlotId,
                      genGenesisAvvmBalances, genGenesisConfiguration,
                      genGenesisDelegation, genGenesisInitializer,
                      genGenesisProtocolConstants, genInvReqDataFlowLog,
@@ -22,7 +23,49 @@ import           Test.Pos.Util.Tripping (discoverRoundTrip,
 import           Universum
 
 --------------------------------------------------------------------------------
--- GensisConfiguration
+-- Address
+--------------------------------------------------------------------------------
+
+golden_Address0 :: Property
+golden_Address0 =
+    goldenTestJSON
+        exampleAddress
+        "test/golden/json/Address0"
+
+golden_Address1 :: Property
+golden_Address1 =
+    goldenTestJSON
+        exampleAddress1
+        "test/golden/json/Address1"
+
+golden_Address2 :: Property
+golden_Address2 =
+    goldenTestJSON
+        exampleAddress2
+        "test/golden/json/Address2"
+
+golden_Address3 :: Property
+golden_Address3 =
+    goldenTestJSON
+        exampleAddress3
+        "test/golden/json/Address3"
+
+golden_Address4 :: Property
+golden_Address4 =
+    goldenTestJSON
+        exampleAddress4
+        "test/golden/json/Address4"
+
+roundTripAddressShow :: Property
+roundTripAddressShow =
+    eachOf 100 genAddress roundTripsAesonShow
+
+roundTripAddressBuildable :: Property
+roundTripAddressBuildable =
+    eachOf 100 genAddress roundTripsAesonBuildable
+
+--------------------------------------------------------------------------------
+-- GenesisConfiguration
 --------------------------------------------------------------------------------
 
 golden_GenesisConfiguration_GCSpec :: Property

core/test/golden/Address renamed to core/test/golden/bi/Address0

@@ -0,0 +1,3 @@
+00: 82d818582183581caa5372095aaa680d
+10: 19d4ca496983a145709c3be18b0d4c83
+20: cb7bdc5ea0001a32dc988e

core/test/golden/bi/Address1

@@ -0,0 +1,8 @@
+00: 82d818586983581ce269a51e06c374cb
+10: 7bf5a4d36e6d673560ebfa8f2d0cfac4
+20: 3ed4672ca20058208200581c5125b558
+30: daa14b5338e904cc2a75a8b7b3a4738d
+40: e9cb28a6819576db0158225820366574
+50: 4e6f756958657a4379456a4b63337447
+60: 346a61306b466a4f38717a6169021a28
+70: 7cce6a

core/test/golden/bi/Address2

@@ -0,0 +1,15 @@
+00: 82d81858e483581c41574eefbf61b89d
+10: 19ddbc68c760dbf2fe59fc386bae1bd9
+20: 87083453a200589b8201a4581c41cad7
+30: 50a98f3ccd30a8d0b641253151de8fd8
+40: 45ee12e6ff44cf899c1b000000e8d4a5
+50: 1000581c5125b558daa14b5338e904cc
+60: 2a75a8b7b3a4738de9cb28a6819576db
+70: 1b00038c831b679369581c67f62c82d6
+80: 3613496ae4a8b2f7461d7a8a5a31cdb4
+90: 961b26a58db04a1b000000123ede4000
+a0: 581ca0f124f5f822d9fa2093ede304b6
+b0: 43741a980fc1e5c10e8c932560d31a75
+c0: db9c970158225820744e6f756958657a
+d0: 4379456a4b63337447346a61306b466a
+e0: 4f38717a61693236011a3ac2e65f

core/test/golden/bi/Address3

@@ -0,0 +1,5 @@
+00: 82d818584483581ceb7f1fc78b406264
+10: c7e41bd42648978aaf5ad7c2c8632af7
+20: f1ed7375a10058208200581c5125b558
+30: daa14b5338e904cc2a75a8b7b3a4738d
+40: e9cb28a6819576db071a9c486f4b

core/test/golden/bi/Address4

@@ -0,0 +1 @@
+"2RhQhCGqYPDpFgTsnBTbnvPvCwpqAkjwLqQkWpkqXbLRmNxd4xNd262nGsr8JiynyKRUeMLSJ9Ntho9i76uvBTrVXdJJG5yiNLb8frmUe5qX7E"

core/test/golden/json/Address0

@@ -0,0 +1 @@
+"Ae2tdPwUPEZDoUnyXuAgqzhkjNXNJeiZ5nqwprg9sArZmRNjySfJ5uz4FjB"

core/test/golden/json/Address1

@@ -0,0 +1 @@
+"dRNpRgY7sgwXaGbEZQ7KtFprY5PE3sxejht9kFEKLmSowgUegSinCjx3yuKGHQbRHL2EUP89BuAurEScfrgWxahCjD1M9QKYoTj5KrbR5TDnqBE3oSNx7UcXhrGKM9aau48SASu8i88Sq8hPb3z5K662spTXX"

core/test/golden/json/Address2

@@ -0,0 +1 @@
+"a2x5MVsL5Pr1SESUZbGb7d64coe2VpRJhEFsYCUHfaimAE3wvmNHd44H7ue1wFx1RqrS9vnAmTVri19FttwaRLWG5L2rLMe1tCSzZ4zJjeUwej8kEX4VmYbL7t7o1rmucebNvz8qGod2s6LKCkAxN6dWVv9jZ3gCkWrNsXq3JeSjaBLPT7RNwSExRmPAwJ6geZmadnKSArbiPjYXkaJa5GQyDUYbni8jCyXmMHB7Qsj1Pgc7qCKA7AebV13kADRv3wSbMgWEAbBrxEmBRnHgXw5Nh6EJ5n7ejVYJAJY3kJ8Q2xisLJxW54Y48BK8a4AW7M3fU"

core/test/golden/json/Address3

@@ -0,0 +1 @@
+"5FCjkr138i9wjRVwawmYMd4Vc9KxU7TuQhMyjMGpnykg9yb2qMpUCerDFzXvfAJMFgJTHyD7Sn4ybLXm2M6zeWAaWe7ctjq5QjVL427vGRx"