Address Discrimination Not Checked When Sending Transactions

[KtorZ]

Context

Commit Hash / Release Tag	input-output-hk/cardano-ls@release/2.0.0
Operating System	(Windows, OSX, Linux)

On release/2.0.0, one can attempt to construct and send transactions to addresses which are of a different network via the wallet-new V1 API. Even though the nodes reject this transaction since it's invalid (as a result of CO-410), an error should be returned by the API in order to prevent users from even attempting this.

Steps to Reproduce

1. Manually craft a Cardano Address using a wrong protocol magic
2. Use this address in a transaction

Expected behavior

The wallet backend API should reject this transaction request.

Actual behavior

Transaction is accepted by the wallet, and later appears as failed when rejected by the node.

---

PR

Number	Base
input-output-hk/cardano-sl#3823	develop

Retrospective

This isn't the first discrepancy we notice between nodes and wallet in terms of performed checks (cf the fee calculation round vs ceiling ...) and it's probably worth investigating further to catch potential bugs.