Generalize InspectLedger and trace hard fork transitions #2449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
reviewed
Jul 22, 2020
ouroboros-consensus/src/Ouroboros/Consensus/HardFork/Combinator/Ledger.hs
Show resolved
Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/HardFork/Combinator/Ledger.hs
Show resolved
Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/HardFork/Combinator/Ledger.hs
Show resolved
Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/HardFork/Combinator/Ledger.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/ouroboros-consensus-test-infra/src/Test/Util/Serialisation/Golden.hs
Show resolved
Hide resolved
ouroboros-consensus/ouroboros-consensus-mock/src/Ouroboros/Consensus/Mock/Ledger/Address.hs
Show resolved
Hide resolved
mrBliss
approved these changes
Jul 22, 2020
edsko
force-pushed
the
edsko/generalize-inspect
branch
from
6fc2494 to
8deb9e9
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 22, 2020
2449: Generalize InspectLedger and trace hard fork transitions r=edsko a=edsko Co-authored-by: Edsko de Vries <[email protected]>
|
bors r- |
Canceled |
edsko
force-pushed
the
edsko/generalize-inspect
branch
from
6546a0f to
9a8c4db
Compare
Make it clear that it's not a proper `Show` instance, but do insert some brackets to avoid ambiguity when used in larger contexts.
edsko
force-pushed
the
edsko/generalize-inspect
branch
from
9a8c4db to
c5323ad
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 22, 2020
2449: Generalize InspectLedger and trace hard fork transitions r=edsko a=edsko Co-authored-by: Edsko de Vries <[email protected]>
|
bors r- |
Canceled |
This disables the warning about the transition point going from known to unknown, but this can in fact happen: ``` cabal run ouroboros-consensus-cardano:test:test -- -p convergence --quickcheck-replay=937983 ``` To be addressed separatately.
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.