RootPeersDNS: garbage collect DNS results && test single source of truth #3643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
force-pushed
the
bolt12/rootpeerdns-test
branch
from
d1f649a to
5f7ddd7
Compare
coot
reviewed
Mar 1, 2022
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Outdated
Show resolved
Hide resolved
bolt12
force-pushed
the
bolt12/rootpeerdns-test
branch
from
5f7ddd7 to
ea6b4ce
Compare
coot
reviewed
Mar 3, 2022
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Outdated
Show resolved
Hide resolved
coot
reviewed
Mar 3, 2022
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Outdated
Show resolved
Hide resolved
bolt12
force-pushed
the
bolt12/rootpeerdns-test
branch
from
ea6b4ce to
d565c36
Compare
bolt12
force-pushed
the
bolt12/rootpeerdns-test
branch
from
d565c36 to
830987d
Compare
bolt12
force-pushed
the
bolt12/rootpeerdns-test
branch
from
830987d to
be29415
Compare
bolt12
force-pushed
the
bolt12/rootpeerdns-test
branch
from
be29415 to
33af6b3
Compare
bolt12
changed the title
coot
approved these changes
Mar 16, 2022
ouroboros-network/test/Test/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Show resolved
Hide resolved
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 16, 2022
3643: RootPeersDNS: garbage collect DNS results && test single source of truth r=bolt12 a=bolt12 This PR extends the existing test suite for RootPeersDNS by making the MockRoots more robust, and adding a test to check if localRootPeersProvider has a single source of truth. It also fixes #3650. This was motivated by a bug found by `@karknu` and fixed in #3641 . Co-authored-by: Armando Santos <[email protected]>
|
bors cancel |
|
Canceled. |
bolt12
force-pushed
the
bolt12/rootpeerdns-test
branch
from
33af6b3 to
9ff0c2f
Compare
|
bors merge |
|
Build succeeded: |
coot
pushed a commit
that referenced
this pull request
May 16, 2022
3643: RootPeersDNS: garbage collect DNS results && test single source of truth r=bolt12 a=bolt12 This PR extends the existing test suite for RootPeersDNS by making the MockRoots more robust, and adding a test to check if localRootPeersProvider has a single source of truth. It also fixes #3650. This was motivated by a bug found by `@karknu` and fixed in #3641 . Co-authored-by: Armando Santos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the existing test suite for RootPeersDNS by making the MockRoots more robust, and adding a test to check if localRootPeersProvider has a single source of truth. It also fixes #3650.
This was motivated by a bug found by @karknu and fixed in #3641 .