Skip to content

Commit 5839d44

Browse files
author
Muhammad Farooq
committed
Fixed issue with Html-loader where it was tempering with angular specific tags webpack-contrib/html-loader#67
1 parent 7f19b5f commit 5839d44

File tree

2 files changed

+24
-13
lines changed

2 files changed

+24
-13
lines changed

src/app/config/webpack.common.js

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,18 @@ module.exports = {
2828
loaders: ['awesome-typescript-loader', 'angular2-template-loader']
2929
}, {
3030
test: /\.html$/,
31-
loader: 'html-loader'
31+
loader: 'html-loader',
32+
options: {
33+
minimize: true,
34+
removeComments: true,
35+
collapseWhitespace: true,
36+
37+
// angular 2 templates break if these are omitted
38+
removeAttributeQuotes: false,
39+
keepClosingSlash: true,
40+
caseSensitive: true,
41+
conservativeCollapse: true,
42+
}
3243
}, {
3344
test: /\.(png|jpe?g|gif|svg|woff|woff2|ttf|eot|ico)$/,
3445
loader: 'file-loader?name=assets/[name].[hash].[ext]'

src/app/package.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -62,28 +62,28 @@
6262
"electron-builder": "^19.18.1"
6363
},
6464
"dependencies": {
65-
"@angular/common": "^4.4.1",
66-
"@angular/compiler": "^4.4.1",
67-
"@angular/core": "^4.4.1",
68-
"@angular/forms": "^4.4.1",
69-
"@angular/http": "^4.4.1",
70-
"@angular/platform-browser": "^4.4.1",
71-
"@angular/platform-browser-dynamic": "^4.4.1",
72-
"@angular/router": "^4.4.1",
65+
"@angular/common": "^4.4.4",
66+
"@angular/compiler": "^4.4.4",
67+
"@angular/core": "^4.4.4",
68+
"@angular/forms": "^4.4.4",
69+
"@angular/http": "^4.4.4",
70+
"@angular/platform-browser": "^4.4.4",
71+
"@angular/platform-browser-dynamic": "^4.4.4",
72+
"@angular/router": "^4.4.4",
7373
"@ngx-translate/core": "^8.0.0",
7474
"@ngx-translate/http-loader": "^2.0.0",
7575
"@toverux/ngsweetalert2": "^1.2.2",
76-
"angular-oauth2-oidc": "^2.1.3",
76+
"angular-oauth2-oidc": "^2.1.8",
7777
"bootstrap": "^3.3.7",
7878
"bootstrap-notify": "^3.1.3",
7979
"core-js": "^2.5.1",
80-
"electron-reload": "^1.2.1",
80+
"electron-reload": "^1.2.2",
8181
"jquery": "^3.2.1",
8282
"lodash": "^4.17.4",
8383
"ng2-auto-complete": "^0.12.0",
8484
"ng2-bootstrap-modal": "^1.0.1",
8585
"rxjs": "^5.4.3",
86-
"sweetalert2": "^6.9.0",
87-
"zone.js": "^0.8.17"
86+
"sweetalert2": "^6.10.1",
87+
"zone.js": "^0.8.18"
8888
}
8989
}

0 commit comments

Comments
 (0)