Skip to content

Add test for --skips flag #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
terriko opened this issue Aug 7, 2019 · 4 comments · Fixed by #327
Closed

Add test for --skips flag #199

terriko opened this issue Aug 7, 2019 · 4 comments · Fixed by #327
Labels
good first issue Good for newcomers

Comments

@terriko
Copy link
Contributor

terriko commented Aug 7, 2019

The CVE Binary Tool as a --skips flag that allows you to specify a list of checkers to skip. It currently has no test.

Ideally, you should have it scan a file that should have a cve (maybe use one of the short tests in test_scanner.py) and show that it finds something when the flag is not used, and finds nothing when the relevant checker is skipped.

But honestly, just a test to make sure the flag outputs something meaningful and doesn't fail when used would probably be a good start here. You can see some similar tests in test_cli.py.

@terriko terriko added the good first issue Good for newcomers label Aug 7, 2019
@Patil2099
Copy link

@terriko Can you work on this issue?

@terriko
Copy link
Contributor Author

terriko commented Sep 11, 2019

@Patil2099 Do you need a test for this for some specific reason? I was going to leave this open for new contributors rather than work on it myself.

@Patil2099
Copy link

@terriko I am really sorry. I forgot about it. I will work on it today.

@terriko terriko added the hacktoberfest good issue for hacktoberfest participation label Oct 15, 2019
@terriko terriko removed the hacktoberfest good issue for hacktoberfest participation label Jan 8, 2020
@terriko
Copy link
Contributor Author

terriko commented Jan 8, 2020

removing hacktoberfest label since the contest is over. This remains available for new contributors to work on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants