Skip to content

Commit 0c51f60

Browse files
authored
[SYCL] Switch SPIR-V offload target to opaque pointers (#9828)
Although there are a few tests failing due to this change, we need to go with this change to avoid future regressions and unblock changes removing typed pointers support. The regressions are supposed to be fixed by follow-up patches.
1 parent bca2cd2 commit 0c51f60

File tree

8 files changed

+22
-2
lines changed

8 files changed

+22
-2
lines changed

llvm/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,7 @@ set(DPCPP_ENABLE_OPAQUE_POINTERS TRUE CACHE BOOL
893893
if (DPCPP_ENABLE_OPAQUE_POINTERS)
894894
add_definitions("-DENABLE_OPAQUE_POINTERS=1")
895895
endif(DPCPP_ENABLE_OPAQUE_POINTERS)
896-
set(SPIRV_ENABLE_OPAQUE_POINTERS FALSE CACHE BOOL
896+
set(SPIRV_ENABLE_OPAQUE_POINTERS TRUE CACHE BOOL
897897
"Enable opaque pointers for SPIR-V offload by default.")
898898
if(SPIRV_ENABLE_OPAQUE_POINTERS)
899899
add_definitions("-DSPIRV_ENABLE_OPAQUE_POINTERS=1")

sycl/test-e2e/BFloat16/bfloat16_conversions.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
// software emulation.
66
// UNSUPPORTED: accelerator
77

8+
// FIXME: enable opaque pointers support on CPU.
9+
// UNSUPPORTED: cpu
10+
811
//==---------- bfloat16_conversions.cpp - SYCL bfloat16 type test ---------==//
912
//
1013
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.

sycl/test-e2e/BFloat16/bfloat16_type.cpp

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55

66
// TODO currently the feature isn't supported on FPGA.
77
// UNSUPPORTED: accelerator
8-
//
8+
9+
// FIXME: enable opaque pointers support on CPU.
10+
// UNSUPPORTED: cpu
911

1012
//==----------- bfloat16_type.cpp - SYCL bfloat16 type test ----------------==//
1113
//

sycl/test-e2e/DeviceLib/string_test.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
// RUN: %{build} -fno-builtin -fsycl-device-lib-jit-link -o %t.out
66
// RUN: %if !gpu %{ %{run} %t.out %}
77

8+
// FIXME: enable opaque pointers support on CPU.
9+
// UNSUPPORTED: cpu
10+
811
#include <cassert>
912
#include <cstdint>
1013
#include <cstring>

sycl/test-e2e/ESIMD/ext_math.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
// RUN: %{build} -fsycl-device-code-split=per_kernel %{mathflags} -o %t.out
1010
// RUN: %{run} %t.out
1111

12+
// FIXME: enable opaque pointers support
13+
// REQUIRES: TEMPORARY_DISABLED
14+
1215
// This test checks extended math operations. Combinations of
1316
// - argument type - half, float
1417
// - math function - sin, cos, ..., div_ieee, pow

sycl/test-e2e/KernelFusion/internalize_array_wrapper.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// RUN: %{build} -fsycl-embed-ir -O2 -o %t.out
33
// RUN: %{run} %t.out
44

5+
// FIXME: enable opaque pointers support
6+
// REQUIRES: TEMPORARY_DISABLED
7+
58
// Test internalization of a nested array type.
69

710
#include <array>

sycl/test-e2e/Reduction/reduction_usm.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@
77
// Windows doesn't yet have full shutdown().
88
// UNSUPPORTED: ze_debug && windows
99

10+
// FIXME: enable opaque pointers support
11+
// REQUIRES: TEMPORARY_DISABLED
12+
1013
// This test performs basic checks of parallel_for(nd_range, reduction, func)
1114
// with reductions initialized with USM pointer.
1215

sycl/test-e2e/Regression/local-arg-align.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
//
33
// RUN: %{run} %t.out
44

5+
// FIXME: enable opaque pointers support
6+
// REQUIRES: TEMPORARY_DISABLED
7+
58
//==-- local-arg-align.cpp - Test for local argument alignmnent ------------==//
69
//
710
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.

0 commit comments

Comments
 (0)