Skip to content

Commit 0ccc0b1

Browse files
committed
[Reproducers] Disable registering lldb::thread_t everywhere
As discussed on the mailing list, default serialization for thread ids is not correct, even if they're represented as basic types. I'm purposely leaving the corresponding record macros in place so that we don't break the API boundary detection. llvm-svn: 355610
1 parent 6f7c536 commit 0ccc0b1

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

lldb/source/API/SBReproducer.cpp

-11
Original file line numberDiff line numberDiff line change
@@ -1116,17 +1116,6 @@ SBRegistry::SBRegistry() {
11161116
LLDB_REGISTER_STATIC_METHOD(lldb::SBFileSpec, SBHostOS,
11171117
GetUserHomeDirectory, ());
11181118
LLDB_REGISTER_STATIC_METHOD(void, SBHostOS, ThreadCreated, (const char *));
1119-
#ifndef _WIN32
1120-
// FIXME: On Windows, lldb::thread_t is just a void*, so the we will try to
1121-
// allocate an object of type void when deserializing.
1122-
LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadCancel,
1123-
(lldb::thread_t, lldb::SBError *));
1124-
LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadDetach,
1125-
(lldb::thread_t, lldb::SBError *));
1126-
LLDB_REGISTER_STATIC_METHOD(
1127-
bool, SBHostOS, ThreadJoin,
1128-
(lldb::thread_t, lldb::thread_result_t *, lldb::SBError *));
1129-
#endif
11301119
}
11311120
{
11321121
LLDB_REGISTER_CONSTRUCTOR(SBInstruction, ());

0 commit comments

Comments
 (0)