Skip to content

Commit 1873f55

Browse files
committed
[MIRVRegNamerUtils] Use Register. NFC
1 parent f611c22 commit 1873f55

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

llvm/lib/CodeGen/MIRVRegNamerUtils.cpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ static cl::opt<bool>
2020
cl::Hidden,
2121
cl::desc("Use Stable Hashing for MIR VReg Renaming"));
2222

23-
using VRegRenameMap = std::map<unsigned, unsigned>;
23+
using VRegRenameMap = std::map<Register, Register>;
2424

2525
bool VRegRenamer::doVRegRenaming(const VRegRenameMap &VRM) {
2626
bool Changed = false;
@@ -45,7 +45,7 @@ VRegRenamer::getVRegRenameMap(const std::vector<NamedVReg> &VRegs) {
4545

4646
VRegRenameMap VRM;
4747
for (const auto &VReg : VRegs) {
48-
const unsigned Reg = VReg.getReg();
48+
const Register Reg = VReg.getReg();
4949
VRM[Reg] = createVirtualRegisterWithLowerName(Reg, GetUniqueVRegName(VReg));
5050
}
5151
return VRM;
@@ -77,7 +77,7 @@ std::string VRegRenamer::getInstructionOpcodeHash(MachineInstr &MI) {
7777
case MachineOperand::MO_Register:
7878
if (MO.getReg().isVirtual())
7979
return MRI.getVRegDef(MO.getReg())->getOpcode();
80-
return MO.getReg();
80+
return MO.getReg().id();
8181
case MachineOperand::MO_Immediate:
8282
return MO.getImm();
8383
case MachineOperand::MO_TargetIndex:
@@ -136,8 +136,8 @@ std::string VRegRenamer::getInstructionOpcodeHash(MachineInstr &MI) {
136136
return OS.str();
137137
}
138138

139-
unsigned VRegRenamer::createVirtualRegister(unsigned VReg) {
140-
assert(Register::isVirtualRegister(VReg) && "Expected Virtual Registers");
139+
Register VRegRenamer::createVirtualRegister(Register VReg) {
140+
assert(VReg.isVirtual() && "Expected Virtual Registers");
141141
std::string Name = getInstructionOpcodeHash(*MRI.getVRegDef(VReg));
142142
return createVirtualRegisterWithLowerName(VReg, Name);
143143
}
@@ -160,10 +160,10 @@ bool VRegRenamer::renameInstsInMBB(MachineBasicBlock *MBB) {
160160
NamedVReg(MO.getReg(), Prefix + getInstructionOpcodeHash(Candidate)));
161161
}
162162

163-
return VRegs.size() ? doVRegRenaming(getVRegRenameMap(VRegs)) : false;
163+
return !VRegs.empty() ? doVRegRenaming(getVRegRenameMap(VRegs)) : false;
164164
}
165165

166-
unsigned VRegRenamer::createVirtualRegisterWithLowerName(unsigned VReg,
166+
Register VRegRenamer::createVirtualRegisterWithLowerName(Register VReg,
167167
StringRef Name) {
168168
std::string LowerName = Name.lower();
169169
const TargetRegisterClass *RC = MRI.getRegClassOrNull(VReg);

llvm/lib/CodeGen/MIRVRegNamerUtils.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -61,19 +61,19 @@ class VRegRenamer {
6161

6262
/// For all the VRegs that are candidates for renaming,
6363
/// return a mapping from old vregs to new vregs with names.
64-
std::map<unsigned, unsigned>
64+
std::map<Register, Register>
6565
getVRegRenameMap(const std::vector<NamedVReg> &VRegs);
6666

6767
/// Perform replacing of registers based on the <old,new> vreg map.
68-
bool doVRegRenaming(const std::map<unsigned, unsigned> &VRegRenameMap);
68+
bool doVRegRenaming(const std::map<Register, Register> &VRegRenameMap);
6969

7070
/// createVirtualRegister - Given an existing vreg, create a named vreg to
7171
/// take its place. The name is determined by calling
7272
/// getInstructionOpcodeHash.
73-
unsigned createVirtualRegister(unsigned VReg);
73+
Register createVirtualRegister(Register VReg);
7474

7575
/// Create a vreg with name and return it.
76-
unsigned createVirtualRegisterWithLowerName(unsigned VReg, StringRef Name);
76+
Register createVirtualRegisterWithLowerName(Register VReg, StringRef Name);
7777

7878
/// Linearly traverse the MachineBasicBlock and rename each instruction's
7979
/// vreg definition based on the semantics of the instruction.

0 commit comments

Comments
 (0)