Skip to content

Commit 4b2357e

Browse files
Revert "[CI] Temporarily disable tests requiring spirv-tools in CI (#16743)"
This reverts commit f12546b.
1 parent e923fbb commit 4b2357e

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

.github/workflows/sycl-linux-build.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,9 +195,6 @@ jobs:
195195
cmake --build $GITHUB_WORKSPACE/build --target check-sycl-unittests
196196
- name: check-llvm-spirv
197197
if: always() && !cancelled() && contains(inputs.changes, 'llvm_spirv')
198-
# Temporary workaround to disable running tests requiring spirv-tools.
199-
env:
200-
LIT_OPTS: "--param disable-spirv-tools=True"
201198
run: |
202199
cmake --build $GITHUB_WORKSPACE/build --target check-llvm-spirv
203200
- name: check-xptifw

.github/workflows/sycl-windows-build.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,6 @@ jobs:
145145
cmake --build build --target check-sycl-unittests
146146
- name: check-llvm-spirv
147147
if: always() && !cancelled() && contains(inputs.changes, 'llvm_spirv')
148-
# Temporary workaround to disable running tests requiring spirv-tools.
149-
env:
150-
LIT_OPTS: "--param disable-spirv-tools=True"
151148
run: |
152149
cmake --build build --target check-llvm-spirv
153150
- name: check-xptifw

llvm-spirv/test/lit.cfg.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,27 +60,24 @@
6060

6161
using_spirv_tools = False
6262

63-
# Explicitly disable using spirv tools, if requested.
64-
disable_spirv_tools = lit_config.params.get("disable-spirv-tools", False)
65-
66-
if config.spirv_tools_have_spirv_as and not disable_spirv_tools:
63+
if config.spirv_tools_have_spirv_as:
6764
llvm_config.add_tool_substitutions(['spirv-as'], [config.spirv_tools_bin_dir])
6865
config.available_features.add('spirv-as')
6966
using_spirv_tools = True
7067

71-
if config.spirv_tools_have_spirv_dis and not disable_spirv_tools:
68+
if config.spirv_tools_have_spirv_dis:
7269
llvm_config.add_tool_substitutions(['spirv-dis'], [config.spirv_tools_bin_dir])
7370
config.available_features.add('spirv-dis')
7471
using_spirv_tools = True
7572

76-
if config.spirv_tools_have_spirv_link and not disable_spirv_tools:
73+
if config.spirv_tools_have_spirv_link:
7774
llvm_config.add_tool_substitutions(['spirv-link'], [config.spirv_tools_bin_dir])
7875
config.available_features.add('spirv-link')
7976
using_spirv_tools = True
8077

8178
# Unlike spirv-{as,dis,link} above, running spirv-val is optional: if spirv-val is
8279
# not available, the test must still run and just skip any spirv-val commands.
83-
if config.spirv_tools_have_spirv_val and not disable_spirv_tools:
80+
if config.spirv_tools_have_spirv_val:
8481
llvm_config.add_tool_substitutions(['spirv-val'], [config.spirv_tools_bin_dir])
8582
using_spirv_tools = True
8683
else:

0 commit comments

Comments
 (0)