Skip to content

Commit 719207d

Browse files
authored
[SYCL][Graph] Bump UR commit to OpenCL kernel update (#12724)
Test the UR commit that enables updating kernel commands in a command-buffer in the OpenCL adapter oneapi-src/unified-runtime#1358
1 parent 30b7cd1 commit 719207d

File tree

3 files changed

+16
-11
lines changed

3 files changed

+16
-11
lines changed

sycl/doc/design/CommandGraph.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -537,10 +537,19 @@ adapter where there is matching support for each function in the list.
537537
| | clGetCommandBufferInfoKHR | No |
538538
| | clCommandSVMMemcpyKHR | No |
539539
| | clCommandSVMMemFillKHR | No |
540+
| urCommandBufferUpdateKernelLaunchExp | clUpdateMutableCommandsKHR | Yes[1] |
540541

541542
We are looking to address these gaps in the future so that SYCL-Graph can be
542543
fully supported on a `cl_khr_command_buffer` backend.
543544

545+
[1] Support for `urCommandBufferUpdateKernelLaunchExp` used to update the
546+
configuration of kernel commands requires an OpenCL implementation with the
547+
[cl_khr_command_buffer_mutable_dispatch](https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#cl_khr_command_buffer_mutable_dispatch)
548+
extension. The optional capabilities that are reported by this extension must
549+
include all of of `CL_MUTABLE_DISPATCH_GLOBAL_OFFSET_KHR`,
550+
`CL_MUTABLE_DISPATCH_GLOBAL_SIZE_KHR`, `CL_MUTABLE_DISPATCH_LOCAL_SIZE_KHR`,
551+
`CL_MUTABLE_DISPATCH_ARGUMENTS_KHR`, and `CL_MUTABLE_DISPATCH_EXEC_INFO_KHR`.
552+
544553
#### UR Command-Buffer Implementation
545554

546555
Many of the OpenCL functions take a `cl_command_queue` parameter which is not

sycl/plugins/unified_runtime/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,13 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
9595
endfunction()
9696

9797
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
98-
# commit 31d0fe153733601fe4864fffb9148d554fe9a7ca
99-
# Merge: 2eea85f2 6a602134
98+
# commit b37fa2c4b09a49839a83228f687c811595fce3fd
99+
# Merge: c7fade0d f61e81e9
100100
# Author: Kenneth Benzie (Benie) <[email protected]>
101-
# Date: Mon Apr 22 14:38:18 2024 +0100
102-
# Merge pull request #1243 from kbenzie/benie/fix-urinfo-device-uuid-printing
103-
# [urinfo] Fix printing of device UUID
104-
set(UNIFIED_RUNTIME_TAG 31d0fe153733601fe4864fffb9148d554fe9a7ca)
101+
# Date: Tue Apr 23 16:17:41 2024 +0100
102+
# Merge pull request #1544 from kbenzie/benie/l0-fix-rhel-error
103+
# [L0] Add missing <iomanip> include
104+
set(UNIFIED_RUNTIME_TAG b37fa2c4b09a49839a83228f687c811595fce3fd)
105105

106106
fetch_adapter_source(level_zero
107107
${UNIFIED_RUNTIME_REPO}

sycl/plugins/unified_runtime/pi2ur.hpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4835,16 +4835,12 @@ inline pi_result piextCommandBufferUpdateKernelLaunch(
48354835
ur_exp_command_buffer_update_kernel_launch_desc_t UrDesc;
48364836

48374837
UrDesc.stype = ur_structure_type_t::
4838-
UR_STRUCTURE_TYPE_EXP_COMMAND_BUFFER_UPDATE_EXEC_INFO_DESC;
4838+
UR_STRUCTURE_TYPE_EXP_COMMAND_BUFFER_UPDATE_KERNEL_LAUNCH_DESC;
48394839
UrDesc.numNewMemObjArgs = desc->num_mem_obj_args;
48404840
UrDesc.numNewPointerArgs = desc->num_ptr_args;
48414841
UrDesc.numNewValueArgs = desc->num_value_args;
48424842
UrDesc.newWorkDim = desc->num_work_dim;
48434843

4844-
// Exec info updates are unused and will be removed from UR in future
4845-
UrDesc.numNewExecInfos = 0;
4846-
UrDesc.pNewExecInfoList = nullptr;
4847-
48484844
// Convert arg descs
48494845
std::vector<ur_exp_command_buffer_update_memobj_arg_desc_t> UrMemObjDescs;
48504846
std::vector<ur_exp_command_buffer_update_pointer_arg_desc_t> UrPointerDescs;

0 commit comments

Comments
 (0)