Skip to content

Commit 759850e

Browse files
[SYCL][NFC] Drop suppression of export related warnings (#17918)
Right now it's applied globally, affecting code other than SYCL headers when included. After removing the pragma, no additional warnings are observed when building on Windows.
1 parent 2d97c28 commit 759850e

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

sycl/include/sycl/detail/export.hpp

-5
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@
1212
#ifndef __SYCL_EXPORT
1313
#ifdef _WIN32
1414

15-
// MSVC discourages export of classes, that use STL class in API. This
16-
// results in a warning, treated as compile error. Silence C4251 to workaround.
17-
#pragma warning(disable : 4251)
18-
#pragma warning(disable : 4275)
19-
2015
#define __SYCL_DLL_LOCAL
2116

2217
#if __SYCL_BUILD_SYCL_DLL

0 commit comments

Comments
 (0)