Skip to content

Commit 8efb79a

Browse files
committed
Review comments fixes
Signed-off-by: Zahira Ammarguellat <[email protected]>
1 parent 84a2cee commit 8efb79a

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

clang/lib/CodeGen/CodeGenFunction.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1529,16 +1529,14 @@ void CodeGenFunction::GenerateCode(GlobalDecl GD, llvm::Function *Fn,
15291529
for (auto ORI : llvm::enumerate(OptReportHandler.GetInfo(FD))) {
15301530
llvm::DiagnosticLocation DL =
15311531
SourceLocToDebugLoc(ORI.value().KernelArgLoc);
1532+
std::string KAN = ORI.value().KernelArgName;
15321533
llvm::OptimizationRemark Remark("sycl", "Region", DL,
15331534
&Fn->getEntryBlock());
15341535
Remark << "Argument " << llvm::ore::NV("Argument", ORI.index())
15351536
<< " for function kernel: "
1536-
<< llvm::ore::NV(ORI.value().KernelArgName.empty() ? "&" : "")
1537-
<< " " << Fn->getName() << "."
1538-
<< llvm::ore::NV(ORI.value().KernelArgName.empty()
1539-
? " "
1540-
: ORI.value().KernelArgName)
1541-
<< "(" << ORI.value().KernelArgType << ")";
1537+
<< llvm::ore::NV(KAN.empty() ? "&" : "") << " " << Fn->getName()
1538+
<< "." << llvm::ore::NV(KAN.empty() ? " " : KAN) << "("
1539+
<< ORI.value().KernelArgType << ")";
15421540
ORE.emit(Remark);
15431541
}
15441542
}

0 commit comments

Comments
 (0)