Skip to content

Commit 94894ee

Browse files
authored
[SYCL][FPGA][NFC] Change the identifier names (#7596)
This patch changes the identifier names because we do not use FPGA attribute spelling anymore (Ref: #4532) Fixes #5105 Signed-off-by: Soumi Manna [[email protected]](mailto:[email protected])
1 parent 63c749c commit 94894ee

21 files changed

+777
-769
lines changed

clang/include/clang/Basic/Attr.td

+95-88
Large diffs are not rendered by default.

clang/include/clang/Basic/AttrDocs.td

+23-23
Original file line numberDiff line numberDiff line change
@@ -2331,7 +2331,7 @@ as ``-mlong-calls`` and ``-mno-long-calls``.
23312331
}];
23322332
}
23332333

2334-
def IntelFPGADoublePumpAttrDocs : Documentation {
2334+
def SYCLIntelDoublePumpAttrDocs : Documentation {
23352335
let Category = DocCatVariable;
23362336
let Heading = "intel::doublepump";
23372337
let Content = [{
@@ -2352,7 +2352,7 @@ that is clocked at twice the rate of its accessors.
23522352
}];
23532353
}
23542354

2355-
def IntelFPGASinglePumpAttrDocs : Documentation {
2355+
def SYCLIntelSinglePumpAttrDocs : Documentation {
23562356
let Category = DocCatVariable;
23572357
let Heading = "intel::singlepump";
23582358
let Content = [{
@@ -2373,7 +2373,7 @@ that is clocked at the same rate as its accessors.
23732373
}];
23742374
}
23752375

2376-
def IntelFPGAMemoryAttrDocs : Documentation {
2376+
def SYCLIntelMemoryAttrDocs : Documentation {
23772377
let Category = DocCatVariable;
23782378
let Heading = "intel::fpga_memory";
23792379
let Content = [{
@@ -2397,7 +2397,7 @@ it indicates what type of memory to use.
23972397
}];
23982398
}
23992399

2400-
def IntelFPGARegisterAttrDocs : Documentation {
2400+
def SYCLIntelRegisterAttrDocs : Documentation {
24012401
let Category = DocCatVariable;
24022402
let Heading = "intel::fpga_register";
24032403
let Content = [{
@@ -2418,7 +2418,7 @@ if possible.
24182418
}];
24192419
}
24202420

2421-
def IntelFPGABankWidthAttrDocs : Documentation {
2421+
def SYCLIntelBankWidthAttrDocs : Documentation {
24222422
let Category = DocCatVariable;
24232423
let Heading = "intel::bankwidth";
24242424
let Content = [{
@@ -2440,7 +2440,7 @@ with banks that are N bytes wide.
24402440
}];
24412441
}
24422442

2443-
def IntelFPGANumBanksAttrDocs : Documentation {
2443+
def SYCLIntelNumBanksAttrDocs : Documentation {
24442444
let Category = DocCatVariable;
24452445
let Heading = "intel::numbanks";
24462446
let Content = [{
@@ -2462,7 +2462,7 @@ with N banks.
24622462
}];
24632463
}
24642464

2465-
def IntelFPGAPrivateCopiesAttrDocs : Documentation {
2465+
def SYCLIntelPrivateCopiesAttrDocs : Documentation {
24662466
let Category = DocCatVariable;
24672467
let Heading = "intel::private_copies";
24682468
let Content = [{
@@ -2485,7 +2485,7 @@ threads or loop iterations.
24852485
}];
24862486
}
24872487

2488-
def IntelFPGAMergeAttrDocs : Documentation {
2488+
def SYCLIntelMergeAttrDocs : Documentation {
24892489
let Category = DocCatVariable;
24902490
let Heading = "intel::merge";
24912491
let Content = [{
@@ -2510,7 +2510,7 @@ depth-wise or width-wise manner.
25102510
}];
25112511
}
25122512

2513-
def IntelFPGAMaxReplicatesAttrDocs : Documentation {
2513+
def SYCLIntelMaxReplicatesAttrDocs : Documentation {
25142514
let Category = DocCatVariable;
25152515
let Heading = "intel::max_replicates";
25162516
let Content = [{
@@ -2533,7 +2533,7 @@ simultaneous accesses from different load/store sites in the program.
25332533
}];
25342534
}
25352535

2536-
def IntelFPGASimpleDualPortAttrDocs : Documentation {
2536+
def SYCLIntelSimpleDualPortAttrDocs : Documentation {
25372537
let Category = DocCatVariable;
25382538
let Heading = "intel::simple_dual_port";
25392539
let Content = [{
@@ -2555,7 +2555,7 @@ loads).
25552555
}];
25562556
}
25572557

2558-
def IntelFPGABankBitsDocs : Documentation {
2558+
def SYCLIntelBankBitsDocs : Documentation {
25592559
let Category = DocCatVariable;
25602560
let Heading = "intel::bank_bits";
25612561
let Content = [{
@@ -2583,7 +2583,7 @@ pointer address bits to bank on.
25832583
}];
25842584
}
25852585

2586-
def IntelFPGAForcePow2DepthAttrDocs : Documentation {
2586+
def SYCLIntelForcePow2DepthAttrDocs : Documentation {
25872587
let Category = DocCatVariable;
25882588
let Heading = "intel::force_pow2_depth";
25892589
let Content = [{
@@ -3144,7 +3144,7 @@ sycl_detail namespace.
31443144
}];
31453145
}
31463146

3147-
def SYCLFPGAPipeDocs : Documentation {
3147+
def SYCLIntelPipeDocs : Documentation {
31483148
let Category = DocCatStmt;
31493149
let Heading = "pipe (read_only, write_only)";
31503150
let Content = [{
@@ -3168,7 +3168,7 @@ with which a pipe interfaces. The id argument is the name of the I/O interface.
31683168
}];
31693169
}
31703170

3171-
def SYCLIntelFPGAIVDepAttrDocs : Documentation {
3171+
def SYCLIntelIVDepAttrDocs : Documentation {
31723172
let Category = DocCatVariable;
31733173
let Heading = "intel::ivdep";
31743174
let Content = [{
@@ -3209,7 +3209,7 @@ or 1 is used.
32093209
}];
32103210
}
32113211

3212-
def SYCLIntelFPGAInitiationIntervalAttrDocs : Documentation {
3212+
def SYCLIntelInitiationIntervalAttrDocs : Documentation {
32133213
let Category = DocCatVariable;
32143214
let Heading = "intel::initiation_interval";
32153215
let Content = [{
@@ -3242,7 +3242,7 @@ The ``[[intel::ii]]`` attribute spelling is a deprecated synonym for
32423242
}];
32433243
}
32443244

3245-
def SYCLIntelFPGAMaxConcurrencyAttrDocs : Documentation {
3245+
def SYCLIntelMaxConcurrencyAttrDocs : Documentation {
32463246
let Category = DocCatVariable;
32473247
let Heading = "intel::max_concurrency";
32483248
let Content = [{
@@ -3270,7 +3270,7 @@ same loop or function, or in conjunction with ``disable_loop_pipelining``.
32703270
}];
32713271
}
32723272

3273-
def SYCLIntelFPGALoopCoalesceAttrDocs : Documentation {
3273+
def SYCLIntelLoopCoalesceAttrDocs : Documentation {
32743274
let Category = DocCatVariable;
32753275
let Heading = "intel::loop_coalesce";
32763276
let Content = [{
@@ -3309,7 +3309,7 @@ of the nested loop levels should be coalesced.
33093309
}];
33103310
}
33113311

3312-
def SYCLIntelFPGADisableLoopPipeliningAttrDocs : Documentation {
3312+
def SYCLIntelDisableLoopPipeliningAttrDocs : Documentation {
33133313
let Category = DocCatVariable;
33143314
let Heading = "intel::disable_loop_pipelining";
33153315
let Content = [{
@@ -3332,7 +3332,7 @@ function, or in conjunction with ``max_interleaving``,
33323332
}];
33333333
}
33343334

3335-
def SYCLIntelFPGALoopCountAttrDocs : Documentation {
3335+
def SYCLIntelLoopCountAttrDocs : Documentation {
33363336
let Category = DocCatVariable;
33373337
let Heading = "intel::loop_count_min, intel::loop_count_max, intel::loop_count_avg, intel::loop_count";
33383338
let Content = [{
@@ -3376,7 +3376,7 @@ using PGO.
33763376
}];
33773377
}
33783378

3379-
def SYCLIntelFPGAMaxInterleavingAttrDocs : Documentation {
3379+
def SYCLIntelMaxInterleavingAttrDocs : Documentation {
33803380
let Category = DocCatVariable;
33813381
let Heading = "intel::max_interleaving";
33823382
let Content = [{
@@ -3402,7 +3402,7 @@ used on the same loop in conjunction with disable_loop_pipelining.
34023402
}];
34033403
}
34043404

3405-
def SYCLIntelFPGASpeculatedIterationsAttrDocs : Documentation {
3405+
def SYCLIntelSpeculatedIterationsAttrDocs : Documentation {
34063406
let Category = DocCatVariable;
34073407
let Heading = "intel::speculated_iterations";
34083408
let Content = [{
@@ -3427,7 +3427,7 @@ used on the same loop in conjunction with disable_loop_pipelining.
34273427
}];
34283428
}
34293429

3430-
def SYCLIntelFPGANofusionAttrDocs : Documentation {
3430+
def SYCLIntelNofusionAttrDocs : Documentation {
34313431
let Category = DocCatVariable;
34323432
let Heading = "intel::nofusion";
34333433
let Content = [{
@@ -3451,7 +3451,7 @@ loop should not be fused with any adjacent loop.
34513451
}];
34523452
}
34533453

3454-
def SYCLIntelFPGAMaxReinvocationDelayAttrDocs : Documentation {
3454+
def SYCLIntelMaxReinvocationDelayAttrDocs : Documentation {
34553455
let Category = DocCatVariable;
34563456
let Heading = "intel::max_reinvocation_delay";
34573457
let Content = [{

clang/include/clang/Sema/Sema.h

+46-46
Original file line numberDiff line numberDiff line change
@@ -2277,31 +2277,31 @@ class Sema final {
22772277
/// Same as above, but constructs the AddressSpace index if not provided.
22782278
QualType BuildAddressSpaceAttr(QualType &T, Expr *AddrSpace,
22792279
SourceLocation AttrLoc);
2280-
SYCLIntelFPGAIVDepAttr *
2281-
BuildSYCLIntelFPGAIVDepAttr(const AttributeCommonInfo &CI, Expr *Expr1,
2282-
Expr *Expr2);
2280+
SYCLIntelIVDepAttr *
2281+
BuildSYCLIntelIVDepAttr(const AttributeCommonInfo &CI, Expr *Expr1,
2282+
Expr *Expr2);
22832283
LoopUnrollHintAttr *BuildLoopUnrollHintAttr(const AttributeCommonInfo &A,
22842284
Expr *E);
22852285
OpenCLUnrollHintAttr *
22862286
BuildOpenCLLoopUnrollHintAttr(const AttributeCommonInfo &A, Expr *E);
22872287

2288-
SYCLIntelFPGALoopCountAttr *
2289-
BuildSYCLIntelFPGALoopCountAttr(const AttributeCommonInfo &CI, Expr *E);
2290-
SYCLIntelFPGAInitiationIntervalAttr *
2291-
BuildSYCLIntelFPGAInitiationIntervalAttr(const AttributeCommonInfo &CI,
2292-
Expr *E);
2293-
SYCLIntelFPGAMaxConcurrencyAttr *
2294-
BuildSYCLIntelFPGAMaxConcurrencyAttr(const AttributeCommonInfo &CI, Expr *E);
2295-
SYCLIntelFPGAMaxInterleavingAttr *
2296-
BuildSYCLIntelFPGAMaxInterleavingAttr(const AttributeCommonInfo &CI, Expr *E);
2297-
SYCLIntelFPGASpeculatedIterationsAttr *
2298-
BuildSYCLIntelFPGASpeculatedIterationsAttr(const AttributeCommonInfo &CI,
2299-
Expr *E);
2300-
SYCLIntelFPGALoopCoalesceAttr *
2301-
BuildSYCLIntelFPGALoopCoalesceAttr(const AttributeCommonInfo &CI, Expr *E);
2302-
SYCLIntelFPGAMaxReinvocationDelayAttr *
2303-
BuildSYCLIntelFPGAMaxReinvocationDelayAttr(const AttributeCommonInfo &CI,
2304-
Expr *E);
2288+
SYCLIntelLoopCountAttr *
2289+
BuildSYCLIntelLoopCountAttr(const AttributeCommonInfo &CI, Expr *E);
2290+
SYCLIntelInitiationIntervalAttr *
2291+
BuildSYCLIntelInitiationIntervalAttr(const AttributeCommonInfo &CI,
2292+
Expr *E);
2293+
SYCLIntelMaxConcurrencyAttr *
2294+
BuildSYCLIntelMaxConcurrencyAttr(const AttributeCommonInfo &CI, Expr *E);
2295+
SYCLIntelMaxInterleavingAttr *
2296+
BuildSYCLIntelMaxInterleavingAttr(const AttributeCommonInfo &CI, Expr *E);
2297+
SYCLIntelSpeculatedIterationsAttr *
2298+
BuildSYCLIntelSpeculatedIterationsAttr(const AttributeCommonInfo &CI,
2299+
Expr *E);
2300+
SYCLIntelLoopCoalesceAttr *
2301+
BuildSYCLIntelLoopCoalesceAttr(const AttributeCommonInfo &CI, Expr *E);
2302+
SYCLIntelMaxReinvocationDelayAttr *
2303+
BuildSYCLIntelMaxReinvocationDelayAttr(const AttributeCommonInfo &CI,
2304+
Expr *E);
23052305

23062306
bool CheckQualifiedFunctionForTypeId(QualType T, SourceLocation Loc);
23072307

@@ -10988,7 +10988,7 @@ class Sema final {
1098810988
/// attribute to be added (usually because of a pragma).
1098910989
void AddOptnoneAttributeIfNoConflicts(FunctionDecl *FD, SourceLocation Loc);
1099010990

10991-
void AddIntelFPGABankBitsAttr(Decl *D, const AttributeCommonInfo &CI,
10991+
void AddSYCLIntelBankBitsAttr(Decl *D, const AttributeCommonInfo &CI,
1099210992
Expr **Exprs, unsigned Size);
1099310993
void AddWorkGroupSizeHintAttr(Decl *D, const AttributeCommonInfo &CI,
1099410994
Expr *XDim, Expr *YDim, Expr *ZDim);
@@ -11024,38 +11024,38 @@ class Sema final {
1102411024
Expr *E);
1102511025
SYCLIntelLoopFuseAttr *
1102611026
MergeSYCLIntelLoopFuseAttr(Decl *D, const SYCLIntelLoopFuseAttr &A);
11027-
void AddIntelFPGAPrivateCopiesAttr(Decl *D, const AttributeCommonInfo &CI,
11027+
void AddSYCLIntelPrivateCopiesAttr(Decl *D, const AttributeCommonInfo &CI,
1102811028
Expr *E);
11029-
void AddIntelFPGAMaxReplicatesAttr(Decl *D, const AttributeCommonInfo &CI,
11029+
void AddSYCLIntelMaxReplicatesAttr(Decl *D, const AttributeCommonInfo &CI,
1103011030
Expr *E);
11031-
IntelFPGAMaxReplicatesAttr *
11032-
MergeIntelFPGAMaxReplicatesAttr(Decl *D, const IntelFPGAMaxReplicatesAttr &A);
11033-
void AddIntelFPGAForcePow2DepthAttr(Decl *D, const AttributeCommonInfo &CI,
11031+
SYCLIntelMaxReplicatesAttr *
11032+
MergeSYCLIntelMaxReplicatesAttr(Decl *D, const SYCLIntelMaxReplicatesAttr &A);
11033+
void AddSYCLIntelForcePow2DepthAttr(Decl *D, const AttributeCommonInfo &CI,
1103411034
Expr *E);
11035-
IntelFPGAForcePow2DepthAttr *
11036-
MergeIntelFPGAForcePow2DepthAttr(Decl *D,
11037-
const IntelFPGAForcePow2DepthAttr &A);
11038-
void AddSYCLIntelFPGAInitiationIntervalAttr(Decl *D,
11039-
const AttributeCommonInfo &CI,
11040-
Expr *E);
11041-
SYCLIntelFPGAInitiationIntervalAttr *MergeSYCLIntelFPGAInitiationIntervalAttr(
11042-
Decl *D, const SYCLIntelFPGAInitiationIntervalAttr &A);
11035+
SYCLIntelForcePow2DepthAttr *
11036+
MergeSYCLIntelForcePow2DepthAttr(Decl *D,
11037+
const SYCLIntelForcePow2DepthAttr &A);
11038+
void AddSYCLIntelInitiationIntervalAttr(Decl *D,
11039+
const AttributeCommonInfo &CI,
11040+
Expr *E);
11041+
SYCLIntelInitiationIntervalAttr *MergeSYCLIntelInitiationIntervalAttr(
11042+
Decl *D, const SYCLIntelInitiationIntervalAttr &A);
1104311043

11044-
SYCLIntelFPGAMaxConcurrencyAttr *MergeSYCLIntelFPGAMaxConcurrencyAttr(
11045-
Decl *D, const SYCLIntelFPGAMaxConcurrencyAttr &A);
11044+
SYCLIntelMaxConcurrencyAttr *MergeSYCLIntelMaxConcurrencyAttr(
11045+
Decl *D, const SYCLIntelMaxConcurrencyAttr &A);
1104611046
void AddSYCLIntelMaxGlobalWorkDimAttr(Decl *D, const AttributeCommonInfo &CI,
1104711047
Expr *E);
1104811048
SYCLIntelMaxGlobalWorkDimAttr *
1104911049
MergeSYCLIntelMaxGlobalWorkDimAttr(Decl *D,
1105011050
const SYCLIntelMaxGlobalWorkDimAttr &A);
11051-
void AddIntelFPGABankWidthAttr(Decl *D, const AttributeCommonInfo &CI,
11051+
void AddSYCLIntelBankWidthAttr(Decl *D, const AttributeCommonInfo &CI,
1105211052
Expr *E);
11053-
IntelFPGABankWidthAttr *
11054-
MergeIntelFPGABankWidthAttr(Decl *D, const IntelFPGABankWidthAttr &A);
11055-
void AddIntelFPGANumBanksAttr(Decl *D, const AttributeCommonInfo &CI,
11053+
SYCLIntelBankWidthAttr *
11054+
MergeSYCLIntelBankWidthAttr(Decl *D, const SYCLIntelBankWidthAttr &A);
11055+
void AddSYCLIntelNumBanksAttr(Decl *D, const AttributeCommonInfo &CI,
1105611056
Expr *E);
11057-
IntelFPGANumBanksAttr *
11058-
MergeIntelFPGANumBanksAttr(Decl *D, const IntelFPGANumBanksAttr &A);
11057+
SYCLIntelNumBanksAttr *
11058+
MergeSYCLIntelNumBanksAttr(Decl *D, const SYCLIntelNumBanksAttr &A);
1105911059
SYCLDeviceHasAttr *MergeSYCLDeviceHasAttr(Decl *D,
1106011060
const SYCLDeviceHasAttr &A);
1106111061
void AddSYCLDeviceHasAttr(Decl *D, const AttributeCommonInfo &CI,
@@ -11173,11 +11173,11 @@ class Sema final {
1117311173
SYCLIntelPipeIOAttr *MergeSYCLIntelPipeIOAttr(Decl *D,
1117411174
const SYCLIntelPipeIOAttr &A);
1117511175

11176-
/// AddSYCLIntelFPGAMaxConcurrencyAttr - Adds a max_concurrency attribute to a
11176+
/// AddSYCLIntelMaxConcurrencyAttr - Adds a max_concurrency attribute to a
1117711177
/// particular declaration.
11178-
void AddSYCLIntelFPGAMaxConcurrencyAttr(Decl *D,
11179-
const AttributeCommonInfo &CI,
11180-
Expr *E);
11178+
void AddSYCLIntelMaxConcurrencyAttr(Decl *D,
11179+
const AttributeCommonInfo &CI,
11180+
Expr *E);
1118111181

1118211182
bool checkNSReturnsRetainedReturnType(SourceLocation loc, QualType type);
1118311183
bool checkAllowedSYCLInitializer(VarDecl *VD);

clang/lib/AST/TypePrinter.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -1754,7 +1754,7 @@ void TypePrinter::printAttributedAfter(const AttributedType *T,
17541754
// AttributedType nodes for them.
17551755
break;
17561756

1757-
case attr::SYCLFPGAPipe:
1757+
case attr::SYCLIntelPipe:
17581758
OS << "pipe";
17591759
break;
17601760

0 commit comments

Comments
 (0)