Skip to content

Commit 9de1a48

Browse files
authored
[CI][BuildBot] Fix configure parameter to turn on/off assertions (#1449)
Update post-commit checks to validate builds with and without assertions. Signed-off-by: Alexey Bader <[email protected]>
1 parent 803f6cc commit 9de1a48

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/linux_post_commit.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
strategy:
1111
fail-fast: false
1212
matrix:
13-
config: ["Default", "SharedLibs", "Assertions"]
13+
config: ["Default", "SharedLibs", "NoAssertions"]
1414

1515
steps:
1616
- uses: actions/checkout@v2
@@ -28,8 +28,8 @@ jobs:
2828
SharedLibs)
2929
export ARGS="--shared-libs"
3030
;;
31-
Assertiosn)
32-
export ARGS="--assertions"
31+
NoAssertions)
32+
export ARGS="--no-assertions"
3333
;;
3434
esac
3535
mkdir -p $GITHUB_WORKSPACE/build

buildbot/configure.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ def do_configure(args):
4242
libclc_targets_to_build = 'nvptx64--;nvptx64--nvidiacl'
4343
sycl_build_pi_cuda = 'ON'
4444

45-
if args.assertions:
46-
llvm_enable_assertions = 'ON'
45+
if args.no_assertions:
46+
llvm_enable_assertions = 'OFF'
4747

4848
if args.docs:
4949
llvm_enable_doxygen = 'ON'
@@ -118,7 +118,7 @@ def main():
118118
parser.add_argument("-t", "--build-type",
119119
metavar="BUILD_TYPE", required=True, help="build type, debug or release")
120120
parser.add_argument("--cuda", action='store_true', help="switch from OpenCL to CUDA")
121-
parser.add_argument("--assertions", action='store_true', help="build with assertions")
121+
parser.add_argument("--no-assertions", action='store_true', help="build without assertions")
122122
parser.add_argument("--docs", action='store_true', help="build Doxygen documentation")
123123
parser.add_argument("--no-ocl", action='store_true', help="download OpenCL deps via CMake")
124124
parser.add_argument("--shared-libs", action='store_true', help="Build shared libraries")

0 commit comments

Comments
 (0)