Skip to content

Commit a8cc71e

Browse files
[SYCL] Do not set CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON for plugins (#10702)
We just don't need it: 1) PI interfaces are specifically marked with __SYCL_EXPORT, e.g. https://github.com/intel/llvm/blob/8e0cc4b7a845df9389a1313a3e680babc4d87782/sycl/include/sycl/detail/pi.h#L1148 2) We call to PI interfaces (except for `piPluginInit`) via a pointer from a table set up during `piPluginInit`:https://github.com/intel/llvm/blob/8e0cc4b7a845df9389a1313a3e680babc4d87782/sycl/include/sycl/detail/pi.hpp#L220 Signed-off-by: smaslov <[email protected]>
1 parent c0483d7 commit a8cc71e

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

sycl/plugins/CMakeLists.txt

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)
2-
31
if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang|IntelLLVM" )
42
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-covered-switch-default")
53
endif()

sycl/plugins/level_zero/CMakeLists.txt

-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ if (NOT DEFINED LEVEL_ZERO_LIBRARY OR NOT DEFINED LEVEL_ZERO_INCLUDE_DIR)
88

99
# Disable due to a bug https://github.com/oneapi-src/level-zero/issues/104
1010
set(CMAKE_INCLUDE_CURRENT_DIR OFF)
11-
# Prevent L0 loader from exporting extra symbols
12-
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS OFF)
1311

1412
message(STATUS "Will fetch Level Zero Loader from ${LEVEL_ZERO_LOADER_REPO}")
1513
include(FetchContent)

0 commit comments

Comments
 (0)