Skip to content

Commit ad84669

Browse files
authored
[SYCL][Joint Matrix] Test combinations are queried Part 4 (#14019)
Supported matrix dimensions are queried from the device, and inform the tests which tile sizes one can use. This is a subset of all tests that are planned to be modified. Test manually tested on PVC and SPR - no new regresssions The following tests have been marked as XFAIL on all platforms. I removed them from XMX8 folder. Once they are passing then they can be modified to query the supported matrix dimensions form the device. * joint_matrix_colA_rowB_colC.cpp * joint_matrix_out_bounds.cpp * joint_matrix_unaligned_k.cpp
1 parent 89225ce commit ad84669

17 files changed

+166
-383
lines changed

sycl/test-e2e/Matrix/SG32/joint_matrix_bf16_fill_k_cache.cpp

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,18 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// REQUIRES: matrix
8+
// SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2
9+
// UNSUPPORTED: gpu-intel-dg2
10+
// REQUIRES: aspect-ext_intel_matrix
911
// REQUIRES-INTEL-DRIVER: lin: 27501, win: 101.4943
1012

11-
// RUN: %{build} -o %t_gpu.out -ffp-model=precise
12-
// RUN: %if gpu %{ %{run} %t_gpu.out %}
13-
14-
// RUN: %{build} -ffp-model=precise -o %t_cpu.out -DtM=16 -DtK=32 -DNCACHE1=32 -DKCACHE1=32
15-
// RUN: %if cpu %{ %{run} %t_cpu.out %}
13+
// RUN: %{build} -o %t.out -ffp-model=precise
14+
// RUN: %{run} %t.out
1615

1716
// -ffp-model=precise is added to not depend on compiler defaults.
1817

1918
#include "../common.hpp"
20-
#include <cstddef>
2119

2220
#define SG_SZ 32
23-
constexpr size_t TN = 16;
2421

2522
#include "../joint_matrix_bf16_fill_k_cache_impl.hpp"

sycl/test-e2e/Matrix/SG32/joint_matrix_bf16_fill_k_cache_init.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// REQUIRES: matrix, gpu
8+
// SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2
9+
// UNSUPPORTED: gpu-intel-dg2
10+
// REQUIRES: aspect-ext_intel_matrix, gpu
911
// REQUIRES-INTEL-DRIVER: lin: 27501, win: 101.4943
1012

1113
// RUN: %{build} -o %t.out -DINIT_LIST -ffp-model=precise
@@ -14,9 +16,7 @@
1416
// -ffp-model=precise is added to not depend on compiler defaults.
1517

1618
#include "../common.hpp"
17-
#include <cstddef>
1819

1920
#define SG_SZ 32
20-
constexpr size_t TN = 16;
2121

2222
#include "../joint_matrix_bf16_fill_k_cache_impl.hpp"

sycl/test-e2e/Matrix/SG32/joint_matrix_bf16_fill_k_cache_unroll.cpp

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,20 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// REQUIRES: matrix
8+
// SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2
9+
// UNSUPPORTED: gpu-intel-dg2
10+
// REQUIRES: aspect-ext_intel_matrix
911
// REQUIRES-INTEL-DRIVER: lin: 27501, win: 101.4943
1012

11-
// RUN: %{build} -mllvm -inline-threshold=5000 -ffp-model=precise -o %t_gpu.out -DMANUAL_UNROLL
12-
// RUN: %if gpu %{ %{run} %t_gpu.out %}
13-
14-
// RUN: %{build} -mllvm -inline-threshold=5000 -ffp-model=precise -o %t_cpu.out -DMANUAL_UNROLL -DtM=16 -DtK=32 -DNCACHE1=32 -DKCACHE1=32
15-
// RUN: %if cpu %{ %{run} %t_cpu.out %}
13+
// RUN: %{build} -mllvm -inline-threshold=5000 -ffp-model=precise -o %t.out -DMANUAL_UNROLL
14+
// RUN: %{run} %t.out
1615

1716
// -mllvm -inline-threshold added as a workaround,
1817
// since IGC doesn't support some variants of IR for Joint Matrix currently
1918
// -ffp-model=precise is added to not depend on compiler defaults.
2019

2120
#include "../common.hpp"
22-
#include <cstddef>
2321

2422
#define SG_SZ 32
25-
constexpr size_t TN = 16;
2623

2724
#include "../joint_matrix_bf16_fill_k_cache_impl.hpp"

sycl/test-e2e/Matrix/SG32/joint_matrix_bf16_fill_k_cache_unroll_init.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// REQUIRES: matrix, gpu
8+
// SG size = 32 is not currently supported for SYCL Joint Matrix by IGC on DG2
9+
// UNSUPPORTED: gpu-intel-dg2
10+
// REQUIRES: aspect-ext_intel_matrix, gpu
911
// REQUIRES-INTEL-DRIVER: lin: 27501, win: 101.4943
1012

1113
// RUN: %{build} -mllvm -inline-threshold=5000 -ffp-model=precise -o %t_gpu.out -DINIT_LIST -DMANUAL_UNROLL
@@ -16,9 +18,7 @@
1618
// -ffp-model=precise is added to not depend on compiler defaults.
1719

1820
#include "../common.hpp"
19-
#include <cstddef>
2021

2122
#define SG_SZ 32
22-
constexpr size_t TN = 16;
2323

2424
#include "../joint_matrix_bf16_fill_k_cache_impl.hpp"

sycl/test-e2e/Matrix/XMX8/joint_matrix_bf16_fill_k_cache.cpp

Lines changed: 0 additions & 20 deletions
This file was deleted.

sycl/test-e2e/Matrix/XMX8/joint_matrix_bf16_fill_k_cache_init.cpp

Lines changed: 0 additions & 20 deletions
This file was deleted.

sycl/test-e2e/Matrix/XMX8/joint_matrix_bf16_fill_k_cache_unroll.cpp

Lines changed: 0 additions & 22 deletions
This file was deleted.

sycl/test-e2e/Matrix/XMX8/joint_matrix_bf16_fill_k_cache_unroll_init.cpp

Lines changed: 0 additions & 22 deletions
This file was deleted.

sycl/test-e2e/Matrix/XMX8/joint_matrix_colA_rowB_colC.cpp

Lines changed: 0 additions & 19 deletions
This file was deleted.

sycl/test-e2e/Matrix/XMX8/joint_matrix_out_bounds.cpp

Lines changed: 0 additions & 20 deletions
This file was deleted.

sycl/test-e2e/Matrix/XMX8/joint_matrix_unaligned_k.cpp

Lines changed: 0 additions & 20 deletions
This file was deleted.

sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache.cpp

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,12 @@
55
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
66
//
77
//===----------------------------------------------------------------------===//
8-
// REQUIRES: matrix
8+
// REQUIRES: aspect-ext_intel_matrix
99

10-
// RUN: %{build} -o %t_gpu.out -ffp-model=precise
11-
// RUN: %if gpu %{ %{run} %t_gpu.out %}
12-
13-
// RUN: %{build} -ffp-model=precise -o %t_cpu.out -DtM=16 -DtK=32 -DNCACHE1=32 -DKCACHE1=32
14-
// RUN: %if cpu %{ %{run} %t_cpu.out %}
10+
// RUN: %{build} -o %t.out -ffp-model=precise
11+
// RUN: %{run} %t.out
1512

1613
// -ffp-model=precise is added to not depend on compiler defaults.
1714

1815
#include "common.hpp"
19-
#include <cstddef>
20-
21-
constexpr size_t TN = 16;
22-
2316
#include "joint_matrix_bf16_fill_k_cache_impl.hpp"

sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_OOB.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,4 @@
1616
// -ffp-model=precise is added to not depend on compiler defaults.
1717

1818
#include "common.hpp"
19-
#include <cstddef>
20-
21-
#define SG_SZ 16
22-
constexpr size_t TN = 16;
23-
2419
#include "joint_matrix_bf16_fill_k_cache_impl.hpp"

0 commit comments

Comments
 (0)