Skip to content

Commit c52a260

Browse files
authored
[SYCL][NFC] Pass impl by reference in fill_copy_arg (#17009)
There is no need to pass by value in this case. Shows up in coverity.
1 parent 61eb562 commit c52a260

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

sycl/source/handler.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ fill_image_desc(const ext::oneapi::experimental::image_descriptor &ImgDesc) {
187187
}
188188

189189
static void
190-
fill_copy_args(std::shared_ptr<detail::handler_impl> impl,
190+
fill_copy_args(std::shared_ptr<detail::handler_impl> &impl,
191191
const ext::oneapi::experimental::image_descriptor &SrcImgDesc,
192192
const ext::oneapi::experimental::image_descriptor &DestImgDesc,
193193
ur_exp_image_copy_flags_t ImageCopyFlags, size_t SrcPitch,
@@ -254,7 +254,7 @@ fill_copy_args(std::shared_ptr<detail::handler_impl> impl,
254254
}
255255

256256
static void
257-
fill_copy_args(std::shared_ptr<detail::handler_impl> impl,
257+
fill_copy_args(std::shared_ptr<detail::handler_impl> &impl,
258258
const ext::oneapi::experimental::image_descriptor &Desc,
259259
ur_exp_image_copy_flags_t ImageCopyFlags,
260260
sycl::range<3> SrcOffset = {0, 0, 0},
@@ -269,7 +269,7 @@ fill_copy_args(std::shared_ptr<detail::handler_impl> impl,
269269
}
270270

271271
static void
272-
fill_copy_args(std::shared_ptr<detail::handler_impl> impl,
272+
fill_copy_args(std::shared_ptr<detail::handler_impl> &impl,
273273
const ext::oneapi::experimental::image_descriptor &Desc,
274274
ur_exp_image_copy_flags_t ImageCopyFlags, size_t SrcPitch,
275275
size_t DestPitch, sycl::range<3> SrcOffset = {0, 0, 0},
@@ -283,7 +283,7 @@ fill_copy_args(std::shared_ptr<detail::handler_impl> impl,
283283
}
284284

285285
static void
286-
fill_copy_args(std::shared_ptr<detail::handler_impl> impl,
286+
fill_copy_args(std::shared_ptr<detail::handler_impl> &impl,
287287
const ext::oneapi::experimental::image_descriptor &SrcImgDesc,
288288
const ext::oneapi::experimental::image_descriptor &DestImgDesc,
289289
ur_exp_image_copy_flags_t ImageCopyFlags,

0 commit comments

Comments
 (0)