[SYCL] Fix static code analyzis concerns.

Signed-off-by: Mikhail Lychkov <[email protected]>

Author: mlychkov

clang/lib/CodeGen/CGSYCLRuntime.cpp

@@ -104,7 +104,7 @@ bool Util::matchQualifiedTypeName(const CXXRecordDecl *RecTy,
   // (namespace) and name.
   if (!RecTy)
     return false; // only classes/structs supported
-  const auto *Ctx = dyn_cast<DeclContext>(RecTy);
+  const auto *Ctx = cast<DeclContext>(RecTy);
   StringRef Name = "";
 
   for (const auto &Scope : llvm::reverse(Scopes)) {

clang/lib/CodeGen/SYCLLowerIR/LowerWGScope.cpp

@@ -662,14 +662,14 @@ static void fixupPrivateMemoryPFWILambdaCaptures(CallInst *PFWICall) {
   // now rewrite the captured addresss of a private_memory variables within the
   // PFWI lambda object:
   for (auto &C : PrivMemCaptures) {
-    GetElementPtrInst *NewGEP = dyn_cast<GetElementPtrInst>(C.second->clone());
+    GetElementPtrInst *NewGEP = cast<GetElementPtrInst>(C.second->clone());
     NewGEP->insertBefore(PFWICall);
     IRBuilder<> Bld(PFWICall->getContext());
     Bld.SetInsertPoint(PFWICall);
     Value *Val = C.first;
-    auto ValAS = dyn_cast<PointerType>(Val->getType())->getAddressSpace();
-    auto PtrAS = dyn_cast<PointerType>(NewGEP->getResultElementType())
-                     ->getAddressSpace();
+    auto ValAS = cast<PointerType>(Val->getType())->getAddressSpace();
+    auto PtrAS =
+        cast<PointerType>(NewGEP->getResultElementType())->getAddressSpace();
 
     if (ValAS != PtrAS)
       Val = Bld.CreateAddrSpaceCast(Val, NewGEP->getResultElementType());

clang/lib/Sema/SemaSYCL.cpp

@@ -215,6 +215,8 @@ class MarkDeviceFunction : public RecursiveASTVisitor<MarkDeviceFunction> {
 
     if (FunctionDecl *Callee = e->getDirectCallee()) {
       Callee = Callee->getCanonicalDecl();
+      assert(Callee && "Device function canonical decl must be available");
+
       // Remember that all SYCL kernel functions have deferred
       // instantiation as template functions. It means that
       // all functions used by kernel have already been parsed and have
@@ -254,7 +256,7 @@ class MarkDeviceFunction : public RecursiveASTVisitor<MarkDeviceFunction> {
       }
       // Specifically check if the math library function corresponding to this
       // builtin is supported for SYCL
-      unsigned BuiltinID = (Callee ? Callee->getBuiltinID() : 0);
+      unsigned BuiltinID = Callee->getBuiltinID();
       if (BuiltinID && !IsSyclMathFunc(BuiltinID)) {
         StringRef Name = SemaRef.Context.BuiltinInfo.getName(BuiltinID);
         SemaRef.Diag(e->getExprLoc(), diag::err_builtin_target_unsupported)