Skip to content

Commit d58dbd2

Browse files
fixed code review comments
1 parent ca60c5b commit d58dbd2

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

sycl/test/esimd/simd_view.cpp

+8-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,14 @@ SYCL_ESIMD_FUNCTION void test_simd_view_copy_ctor() {
7272
// test construction from vector.
7373
SYCL_ESIMD_FUNCTION void test_simd_view_from_vector() {
7474
simd<int, 16> s = 0;
75-
simd_view v = s;
75+
simd_view v1 = s;
76+
simd_view v2(s);
77+
// expected-error@+4 {{no matching constructor for initialization of 'simd_view}}
78+
// expected-note@sycl/ext/intel/experimental/esimd/simd_view.hpp:* {{candidate constructor not viable: expects an lvalue for 1st argument}}
79+
// expected-note@sycl/ext/intel/experimental/esimd/simd_view.hpp:* 4+ {{candidate constructor not viable:}}
80+
// expected-note@sycl/ext/intel/experimental/esimd/simd.hpp:* {{candidate template ignored:}}
81+
simd_view<simd<int, 16>, region_base<false, int, 1, 0, 16, 1>> v3(
82+
(simd<int, 16>()));
7683
}
7784

7885
// move constructor transfers the same view of the underlying data.

0 commit comments

Comments
 (0)